From: Rob Herring <robh@kernel.org>
To: Lukasz Majewski <lukma@denx.de>
Cc: Fabio Estevam <festevam@gmail.com>,
krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, broonie@kernel.org,
linux-spi@vger.kernel.org, shawnguo@kernel.org,
linux-arm-kernel@lists.infradead.org,
Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH 1/3] dt-bindings: misc: lwn,bk4-spi: Add binding
Date: Thu, 24 Oct 2024 10:14:02 -0500 [thread overview]
Message-ID: <20241024151402.GA499355-robh@kernel.org> (raw)
In-Reply-To: <20241023171739.475a2bb7@wsk>
On Wed, Oct 23, 2024 at 05:17:39PM +0200, Lukasz Majewski wrote:
> Hi Fabio,
>
> > From: Fabio Estevam <festevam@denx.de>
> >
> > Add a lwn,bk4-spi.yaml binding for Liebherr's BK4 external SPI
> > controller.
> >
> > Currently, the compatible string used for this device is "lwn,bk4",
> > which is the same as the board compatible string documented at
> > fsl.yaml.
> >
> > This causes several dt-schema warnings:
> >
> > make dtbs_check DT_SCHEMA_FILES=fsl.yaml
> > ...
> >
> > ['lwn,bk4'] is too short
> > 'lwn,bk4' is not one of ['tq,imx8dxp-tqma8xdp-mba8xx']
> > 'lwn,bk4' is not one of ['tq,imx8qxp-tqma8xqp-mba8xx']
> > 'lwn,bk4' is not one of ['armadeus,imx1-apf9328', 'fsl,imx1ads']
> > ...
> >
> > Use a more specific "lwn,bk4-spi" compatible string for this
> > device.
> >
>
> Thanks for updating this.
>
> BK4 is another example of to be long-time supported device... :-)
Does that mean we shouldn't be changing this compatible?
Rob
next prev parent reply other threads:[~2024-10-24 15:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 12:00 [PATCH 1/3] dt-bindings: misc: lwn,bk4-spi: Add binding Fabio Estevam
2024-10-23 12:00 ` [PATCH 2/3] spi: spidev: Add an entry for lwn,bk4-spi Fabio Estevam
2024-10-23 12:00 ` [PATCH 3/3] ARM: dts: vf610-bk4: Use the more specific "lwn,bk4-spi" Fabio Estevam
2024-10-23 15:17 ` [PATCH 1/3] dt-bindings: misc: lwn,bk4-spi: Add binding Lukasz Majewski
2024-10-24 15:14 ` Rob Herring [this message]
2024-10-23 16:37 ` Conor Dooley
2024-10-23 17:33 ` Mark Brown
2024-10-23 18:06 ` Conor Dooley
2024-12-02 16:51 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241024151402.GA499355-robh@kernel.org \
--to=robh@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=festevam@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=lukma@denx.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.