From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de,
martin.petersen@oracle.com, joshi.k@samsung.com,
Keith Busch <kbusch@kernel.org>, David Wei <dw@davidwei.uk>
Subject: Re: [PATCHv2] nvme: module parameter to disable pi with offsets
Date: Thu, 24 Oct 2024 17:34:31 +0200 [thread overview]
Message-ID: <20241024153431.GA10173@lst.de> (raw)
In-Reply-To: <20241024152702.2998364-1-kbusch@meta.com>
On Thu, Oct 24, 2024 at 08:27:02AM -0700, Keith Busch wrote:
> +static bool disable_pi = false;
> +module_param(disable_pi, bool, 0444);
> +MODULE_PARM_DESC(disable_pi, "disable protection information if it has an offset");
> +
The variable and module paramter are a bit misnamed now. Also please
add a comment explaining why we have this seemingly odd flag.
prev parent reply other threads:[~2024-10-24 16:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 15:27 [PATCHv2] nvme: module parameter to disable pi with offsets Keith Busch
2024-10-24 15:34 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241024153431.GA10173@lst.de \
--to=hch@lst.de \
--cc=dw@davidwei.uk \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.