From: Peter Zijlstra <peterz@infradead.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Michael Hennerich" <michael.hennerich@analog.com>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH v2] iio: adc: ad7380: use if_not_cond_guard for claim direct
Date: Fri, 25 Oct 2024 10:03:42 +0200 [thread overview]
Message-ID: <20241025080342.GE14555@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20241024-cleanup-if_not_cond_guard-v2-1-1bef98c9fd2e@baylibre.com>
On Thu, Oct 24, 2024 at 11:12:10AM -0500, David Lechner wrote:
> Replace usage of iio_device_claim_direct_scoped() with
> if_not_cond_guard().
>
> This makes fewer lines of code, less indentation, avoids having the
> error return statement in the macro args, and avoids needing to use
> unreachable().
>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
> This is addressing the build failure reported on Peter's locking/test
> branch [1]. I've done a test compile locally with LLVM=1 and it compiles
> successfully.
Updated it. Do note, I had to still: s/if_not_cond_guard/if_not_guard/g on
this.
Assuming it all builds now, I'll push out the two cleanup patches to
tip.
next prev parent reply other threads:[~2024-10-25 8:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 16:12 [PATCH v2] iio: adc: ad7380: use if_not_cond_guard for claim direct David Lechner
2024-10-25 8:03 ` Peter Zijlstra [this message]
2024-10-27 4:27 ` kernel test robot
2024-10-27 5:09 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241025080342.GE14555@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.