Re: [PATCH v6 3/7] mfd: Add new driver for MAX77705 PMIC

[Lee Jones <lee@kernel.org>]

On Mon, 21 Oct 2024, Dzmitry Sankouski wrote:

> > > diff --git a/drivers/mfd/max77705.c b/drivers/mfd/max77705.c
> > > new file mode 100644
> > > index 000000000000..553f20a6cdd5
> > > --- /dev/null
> > > +++ b/drivers/mfd/max77705.c
> > > @@ -0,0 +1,248 @@
> > > +// SPDX-License-Identifier: GPL-2.0+
> > > +//
> > > +// max77705.c - mfd core driver for the MAX77705
> >
> (...)
> > > +// Copyright (C) 2024 Dzmitry Sankouski <dsankouski@gmail.com>
> >
> > Only the SPDX in C++ comments please.
> >
> This conflicts with https://patchwork.kernel.org/comment/25898728/

a) Mark is only talking about the file header

> > > +
> (...)
> 
> > > +++ b/include/linux/mfd/max77705-private.h
> > > @@ -0,0 +1,180 @@
> > > +/* SPDX-License-Identifier: GPL-2.0 */
> > > +//
> > > +// Maxim MAX77705 definitions.
> > > +//
> > > +// Copyright (C) 2015 Samsung Electronics, Inc.
> > > +// Copyright (C) 2024 Dzmitry Sankouski <dsankouski@gmail.com>
> >
> > No C++ please.
> 
> This conflicts with https://patchwork.kernel.org/comment/25898728/

a) Mark is only talking about the file header
b) Different subsystem, different rules.

> 
> >
> > > +
> > > +#ifndef __LINUX_MFD_MAX77705_PRIV_H
> > > +#define __LINUX_MFD_MAX77705_PRIV_H
> > > +
> > > +#include <linux/pm.h>
> > > +
> > > +#define MAX77705_SRC_IRQ_CHG BIT(0)
> > > +#define MAX77705_SRC_IRQ_TOP BIT(1)
> > > +#define MAX77705_SRC_IRQ_FG  BIT(2)
> > > +#define MAX77705_SRC_IRQ_USBC        BIT(3)
> > > +#define MAX77705_SRC_IRQ_ALL (MAX77705_SRC_IRQ_CHG | MAX77705_SRC_IRQ_TOP | \
> > > +                             MAX77705_SRC_IRQ_FG | MAX77705_SRC_IRQ_USBC)
> > > +
> > > +// MAX77705_PMIC_REG_PMICREV register
> >
> > No C++ please.
> 
> This conflicts with https://patchwork.kernel.org/comment/25898728/

a) Mark is only talking about the file header
b) Different subsystem, different rules.

> 
> -- 
> 
> Best regards,
> Dzmitry
> 

-- 
Lee Jones [李琼斯]