From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92E0E1632F6 for ; Fri, 25 Oct 2024 13:01:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729861300; cv=none; b=VqQ6vXwXvWYI7xgghxf4WKt5h+26LW9dLv0ZKOunDHLhF4wlllAagloYtXt2crFSwa3pNR5drwJLkYdY1Hsu3IA09f/+YdG/XIMLUZ1W8fP2PXVIrKmGwv0l1XypAd5zlzzE3HR9t1pjr24Eh1evCbfQGRBT5vAfG7FXn2rZkS8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729861300; c=relaxed/simple; bh=yiHeZgw/FeP5ohbEYLqHAFPfeJLUA2zOv6polMDZ77A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eV/JLUf6KVCn9EYa1Tbnkn208Do5ak2r6RTC6IcuOPkblE/B0zWkoX3wUYll9DdGcPS3nlamcakWwTFApoQ8xQN/ECqkXcKlFmogzQ/9+Xnr+MSn/avYHWx7bBqcBTcI+pZpUc2gYA7Yl6IKwrMD5GtfRLoXwOpM92qNn2ksZ8M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=DS/LncaL; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="DS/LncaL" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-2e56df894d4so1519008a91.3 for ; Fri, 25 Oct 2024 06:01:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1729861298; x=1730466098; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QG9onz68AihZ0/QQ3v1B+iArWlqGlmXiJf2wzvXf6Xg=; b=DS/LncaLYXjhKu+du7HWEc4WTLTr5NXqNE5kQBsXqTHEVe8HilkOQULfuTupG6OctF D5xhewqJtSIsmZkbQ89h+yL6vL5mXCxzCKqpXZ6yBlglX7MGace6DbtqnITOga/ToMZq bAxerFrFpwYuqqxfUzuhOESHbQVBoyQ6KIQ9k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729861298; x=1730466098; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QG9onz68AihZ0/QQ3v1B+iArWlqGlmXiJf2wzvXf6Xg=; b=fDE5dll7t3u47yvmjCZxeABWLd60CBkqH/Wt93NT2fM5B+vazLmqZnQXCdspmUDAIU O98H4KjHXS9Jb7g6bjYz+Tu2wweYFut0NApb6mNRTNAl2tsYtkUmtg96V/kMgAUatJ6f 3iObzeucB0Ypq9TrcAbp+gJt9DkBlPIPCN5FQSwuS5iPJBY08sgXkjy3iQwbnOEIwqkR hvS613vieMzgVL3QyuIudYpKe2k0LWaJ2liid6seSMPls9u9cCNxHqBNvBHdX13JBXld LX42OWLN1SR1FnhDpFTWjJeUACPQEMv8m1LBibQ9G7YZSsnPPPcnxcyjziVTTvDQ8LQm pQEw== X-Forwarded-Encrypted: i=1; AJvYcCWzF33OxiQ/m1gwGK7R7xYRTR9eO+DsNk8VSWjkoCfxJgk8Mmh/XVXMk/utYpLed1XPGCVQc66bra+BXw==@vger.kernel.org X-Gm-Message-State: AOJu0Yw/VO3iAbt+OlSd8jo1uhmidevKzuICTLxhUC5nm/XDg0pn7oa1 uiyLKYX/q7CKJYXaT9px3d8Miht92cpykOZl3dyyy6bBj0HGkg9SJeY0FaLnuQ== X-Google-Smtp-Source: AGHT+IHJnUX93Wrtcww1umjqUe+zoRfp3BcM9ILQsEjYqI3VR2JRbMI+0HgRNN0sieyWVCzDDZYsng== X-Received: by 2002:a17:90a:e2ca:b0:2dd:6969:2096 with SMTP id 98e67ed59e1d1-2e76b70c545mr9870731a91.38.1729861297790; Fri, 25 Oct 2024 06:01:37 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:bd37:bccf:f3e:a9ef]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e8e36a044bsm1352978a91.25.2024.10.25.06.01.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Oct 2024 06:01:37 -0700 (PDT) Date: Fri, 25 Oct 2024 22:01:33 +0900 From: Sergey Senozhatsky To: Bryan O'Donoghue Cc: Sergey Senozhatsky , Stanimir Varbanov , Vikash Garodia , Dikshita Agarwal , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv4 3/3] media: venus: factor out inst destruction routine Message-ID: <20241025130133.GQ1279924@google.com> References: <20241025105104.723764-1-senozhatsky@chromium.org> <20241025105104.723764-4-senozhatsky@chromium.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On (24/10/25 12:43), Bryan O'Donoghue wrote: > On 25/10/2024 11:50, Sergey Senozhatsky wrote: > > - venc_ctrl_deinit(inst); > > Shouldn't you be dropping venc_ctrl_deinit as you have done with > vdec_ctrl_deinit ? Oh, yes, will send out v5 in a bit.