From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B487DD116F6 for ; Fri, 25 Oct 2024 05:59:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WOO61ajMp+njxF9d01ihZjWuvHhP4HrUqFWAVwRCSzg=; b=slcOoDTVxj6lcspDgNaO3yTpJj nZIjLkSiUs+5YvH/x6Tic2miLUueEkw58+m/vEWmdwcdxSDWgey+7gf8tud8TKRqJg98Nohodlxqc AT4kGxUyi2hD67dS+TlKYPPsLb/obhzm7Elu/hLe1RMA32xn+CKdmZbcizCt4wZ8tUqYqku0kPy/y wsZ0RO+m8DRWxSebzfgJSG69M9dPK2sYiK2XXuPV5+xaXSEbVsqOsEcqs4HuSNRMdyNBETG1OMp3x p61o4LbpMokESc5hMMDS91O3hZGxeYnvSMAWykn7MMRMKhPSA40kiKjPbX3WA1g8KSGPwPZIz5Yt6 vKxH/w/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t4DLi-00000002cgL-1IXW; Fri, 25 Oct 2024 05:59:02 +0000 Received: from mgamail.intel.com ([198.175.65.21]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t4DIe-00000002cEC-0eYv for linux-arm-kernel@lists.infradead.org; Fri, 25 Oct 2024 05:55:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729835752; x=1761371752; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=23FWiH3CKzmsNXt1ZdAz5LEfEzzjk6r3RpMxYdw4RFA=; b=BSILFSHEiz02txq3GQTB3h8jYCj56EkYuP3ciWPOWz0B/cyP6vtjMphB F9G2b/EJbiybuW76UrUzyHmnNmcPPiz7dfgVVG8O47zMZFJxvgApzrR6b /FKrFZQTPwML9BZKjCjbzHa57cZLE1Y1EYGR6vtNLHaFWkw+J3cXBNN+H jqW1dFfY0j9Pyk403kOOvQKfZKedCwONyx9L+uzFv6kvC8OAjHhYP02RM BdVXkQJzRoKL8QNOlmHE4ydjTIq8mfNkYidVeZE2fzToG4Ri7M401AKMg lokEHESidwRSODsqgOTKAyMzV7v+Vwo3bxJ6kGftYAngFNBoptiwWTZls Q==; X-CSE-ConnectionGUID: zHPanCm+SmeaefHC9XOUrg== X-CSE-MsgGUID: 50YScr2jTFGIofd89dtqXg== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="29434838" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="29434838" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2024 22:55:47 -0700 X-CSE-ConnectionGUID: yloQ/prCQlaJrmPLL5wONA== X-CSE-MsgGUID: bmK5WEtaRt+0XofvJf9EOw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,231,1725346800"; d="scan'208";a="81651366" Received: from lkp-server01.sh.intel.com (HELO a48cf1aa22e8) ([10.239.97.150]) by orviesa008.jf.intel.com with ESMTP; 24 Oct 2024 22:55:43 -0700 Received: from kbuild by a48cf1aa22e8 with local (Exim 4.96) (envelope-from ) id 1t4DIT-000Xer-0C; Fri, 25 Oct 2024 05:55:41 +0000 Date: Fri, 25 Oct 2024 13:55:26 +0800 From: kernel test robot To: goutongchen , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Will Deacon , Robin Murphy , Joerg Roedel , Jason Gunthorpe , Rob Clark , Dmitry Baryshkov Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, goutongchen , =?utf-8?B?6Iuf5rWp?= Subject: Re: [PATCH] iommu/arm-smmu: Add judgment on the size and granule parameters passed in Message-ID: <202410251339.i3YUd5BO-lkp@intel.com> References: <20241024100224.62942-1-goutongchen@uniontech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241024100224.62942-1-goutongchen@uniontech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241024_225552_281313_920673CC X-CRM114-Status: GOOD ( 14.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi goutongchen, kernel test robot noticed the following build warnings: [auto build test WARNING on soc/for-next] [also build test WARNING on arm-perf/for-next/perf linus/master joro-iommu/next v6.12-rc4 next-20241024] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/goutongchen/iommu-arm-smmu-Add-judgment-on-the-size-and-granule-parameters-passed-in/20241024-181048 base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next patch link: https://lore.kernel.org/r/20241024100224.62942-1-goutongchen%40uniontech.com patch subject: [PATCH] iommu/arm-smmu: Add judgment on the size and granule parameters passed in config: i386-buildonly-randconfig-003-20241025 (https://download.01.org/0day-ci/archive/20241025/202410251339.i3YUd5BO-lkp@intel.com/config) compiler: clang version 19.1.2 (https://github.com/llvm/llvm-project 7ba7d8e2f7b6445b60679da826210cdde29eaf8b) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241025/202410251339.i3YUd5BO-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202410251339.i3YUd5BO-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from drivers/iommu/arm/arm-smmu/arm-smmu.c:24: In file included from include/linux/dma-mapping.h:11: In file included from include/linux/scatterlist.h:8: In file included from include/linux/mm.h:2213: include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" | ~~~~~~~~~~~ ^ ~~~ >> drivers/iommu/arm/arm-smmu/arm-smmu.c:288:6: warning: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Wformat] 287 | "The size or granule passed in is err. size=%lu, granule=%lu\n", | ~~~ | %zu 288 | size, granule); | ^~~~ include/linux/dev_printk.h:154:65: note: expanded from macro 'dev_err' 154 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__) | ~~~ ^~~~~~~~~~~ include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap' 110 | _p_func(dev, fmt, ##__VA_ARGS__); \ | ~~~ ^~~~~~~~~~~ drivers/iommu/arm/arm-smmu/arm-smmu.c:288:12: warning: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Wformat] 287 | "The size or granule passed in is err. size=%lu, granule=%lu\n", | ~~~ | %zu 288 | size, granule); | ^~~~~~~ include/linux/dev_printk.h:154:65: note: expanded from macro 'dev_err' 154 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__) | ~~~ ^~~~~~~~~~~ include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap' 110 | _p_func(dev, fmt, ##__VA_ARGS__); \ | ~~~ ^~~~~~~~~~~ drivers/iommu/arm/arm-smmu/arm-smmu.c:322:6: warning: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Wformat] 321 | "The size or granule passed in is err. size=%lu, granule=%lu\n", | ~~~ | %zu 322 | size, granule); | ^~~~ include/linux/dev_printk.h:154:65: note: expanded from macro 'dev_err' 154 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__) | ~~~ ^~~~~~~~~~~ include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap' 110 | _p_func(dev, fmt, ##__VA_ARGS__); \ | ~~~ ^~~~~~~~~~~ drivers/iommu/arm/arm-smmu/arm-smmu.c:322:12: warning: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Wformat] 321 | "The size or granule passed in is err. size=%lu, granule=%lu\n", | ~~~ | %zu 322 | size, granule); | ^~~~~~~ include/linux/dev_printk.h:154:65: note: expanded from macro 'dev_err' 154 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__) | ~~~ ^~~~~~~~~~~ include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap' 110 | _p_func(dev, fmt, ##__VA_ARGS__); \ | ~~~ ^~~~~~~~~~~ 5 warnings generated. vim +288 drivers/iommu/arm/arm-smmu/arm-smmu.c 276 277 static void arm_smmu_tlb_inv_range_s1(unsigned long iova, size_t size, 278 size_t granule, void *cookie, int reg) 279 { 280 struct arm_smmu_domain *smmu_domain = cookie; 281 struct arm_smmu_device *smmu = smmu_domain->smmu; 282 struct arm_smmu_cfg *cfg = &smmu_domain->cfg; 283 int idx = cfg->cbndx; 284 285 if (size == 0 || granule == 0 || (size % granule) != 0) { 286 dev_err(smmu->dev, 287 "The size or granule passed in is err. size=%lu, granule=%lu\n", > 288 size, granule); 289 return; 290 } 291 292 if (smmu->features & ARM_SMMU_FEAT_COHERENT_WALK) 293 wmb(); 294 295 if (cfg->fmt != ARM_SMMU_CTX_FMT_AARCH64) { 296 iova = (iova >> 12) << 12; 297 iova |= cfg->asid; 298 do { 299 arm_smmu_cb_write(smmu, idx, reg, iova); 300 iova += granule; 301 } while (size -= granule); 302 } else { 303 iova >>= 12; 304 iova |= (u64)cfg->asid << 48; 305 do { 306 arm_smmu_cb_writeq(smmu, idx, reg, iova); 307 iova += granule >> 12; 308 } while (size -= granule); 309 } 310 } 311 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki