From: Tom Rini <trini@konsulko.com>
To: Kever Yang <kever.yang@rock-chips.com>
Cc: Heiko Stuebner <heiko@sntech.de>,
u-boot@lists.denx.de, philipp.tomsich@vrull.eu, sjg@chromium.org,
ukleinek@debian.org
Subject: Re: [PATCH v2 18/18] board: rockchip: add support for Qnap TS433 devices
Date: Fri, 25 Oct 2024 21:36:53 -0600 [thread overview]
Message-ID: <20241026033653.GE4959@bill-the-cat> (raw)
In-Reply-To: <630cc98f-c6df-4773-a9b0-efe7b4d3b9e4@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 1522 bytes --]
On Sat, Oct 26, 2024 at 10:44:59AM +0800, Kever Yang wrote:
> Hi Heiko,
>
> On 2024/10/14 03:24, Heiko Stuebner wrote:
> > The Qnap TS433 is a 4-bay NAS based around the RK3568.
> >
> > Two SATA bays are connected to the RK3568's own SATA controllers while
> > the other two are connected to a JMicron SATA controller living on the
> > PCIe bus.
> >
> > It provides one 2.5Gb and one 1Gb ethernet port as well as 3 usb ports.
> >
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > ---
> > arch/arm/dts/rk3568-qnap-ts433-u-boot.dtsi | 6 ++
> > arch/arm/mach-rockchip/rk3568/Kconfig | 14 ++++
> > board/qnap/ts433/Kconfig | 12 +++
> > board/qnap/ts433/MAINTAINERS | 8 ++
> > configs/qnap-ts433-rk3568_defconfig | 86 ++++++++++++++++++++
> > doc/board/qnap/index.rst | 9 +++
> > doc/board/qnap/ts433.rst | 91 ++++++++++++++++++++++
>
> I got a CI build fail for the doc check:
>
> https://source.denx.de/u-boot/custodians/u-boot-rockchip/-/jobs/929791
>
> checking consistency... failed
> Warning, treated as error:
> /builds/u-boot/custodians/u-boot-rockchip/doc/board/qnap/index.rst:document
> isn't included in any toctree
> make[1]: *** [doc/Makefile:70: htmldocs] Error 2
> make: *** [Makefile:2445: htmldocs] Error 2
>
>
> Hi Tom,
>
> Do you have any suggestion for this kind of error?
Hey, yes, "qnap/index" needs to be listed in doc/board/index.rst
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2024-10-26 3:37 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-13 19:24 [PATCH v2 00/18] Support for rk3568 based QNAP TS433 NAS Heiko Stuebner
2024-10-13 19:24 ` [PATCH v2 01/18] arm64: dts: rockchip: add PCIe supply regulator to Qnap-TS433 Heiko Stuebner
2024-10-21 1:32 ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 02/18] arm64: dts: rockchip: enable second PCIe controller on the Qnap-TS433 Heiko Stuebner
2024-10-13 19:24 ` [PATCH v2 03/18] arm64: dts: rockchip: enable uart0 on Qnap-TS433 Heiko Stuebner
2024-10-25 11:58 ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 04/18] arm64: dts: rockchip: enable usb ports " Heiko Stuebner
2024-10-25 11:58 ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 05/18] arm64: dts: rockchip: add stdout path " Heiko Stuebner
2024-10-25 11:58 ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 06/18] arm64: dts: rockchip: enable sata1+2 " Heiko Stuebner
2024-10-25 11:58 ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 07/18] arm64: dts: rockchip: add board-aliases for Qnap-TS433 Heiko Stuebner
2024-10-25 11:58 ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 08/18] arm64: dts: rockchip: add hdd leds to Qnap-TS433 Heiko Stuebner
2024-10-25 11:59 ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 09/18] arm64: dts: rockchip: enable the tsadc on the Qnap-TS433 Heiko Stuebner
2024-10-25 11:59 ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 10/18] arm64: dts: rockchip: add gpio-keys to Qnap-TS433 Heiko Stuebner
2024-10-25 11:59 ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 11/18] arm64: dts: rockchip: define cpu-supply on the Qnap-TS433 Heiko Stuebner
2024-10-25 11:59 ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 12/18] arm64: dts: rockchip: add missing pmic information on Qnap-TS433 Heiko Stuebner
2024-10-25 11:59 ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 13/18] arm64: dts: rockchip: enable gpu " Heiko Stuebner
2024-10-25 11:59 ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 14/18] arm64: dts: rockchip: add 2 pmu_io_domain supplies for Qnap-TS433 Heiko Stuebner
2024-10-25 12:00 ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 15/18] arm64: dts: rockchip: Simplify network PHY connection on qnap-ts433 Heiko Stuebner
2024-10-25 12:00 ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 16/18] arm64: dts: rockchip: actually enable pmu-io-domains " Heiko Stuebner
2024-10-25 12:00 ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 17/18] arm64: dts: rockchip: add product-data eeproms to QNAP TS433 Heiko Stuebner
2024-10-25 12:00 ` Kever Yang
2024-10-13 19:24 ` [PATCH v2 18/18] board: rockchip: add support for Qnap TS433 devices Heiko Stuebner
2024-10-25 12:01 ` Kever Yang
2024-10-26 2:39 ` Kever Yang
2024-10-28 8:39 ` Kever Yang
2024-10-28 18:49 ` Heiko Stuebner
2024-10-26 2:44 ` Kever Yang
2024-10-26 3:36 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241026033653.GE4959@bill-the-cat \
--to=trini@konsulko.com \
--cc=heiko@sntech.de \
--cc=kever.yang@rock-chips.com \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=ukleinek@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.