From: kernel test robot <lkp@intel.com>
To: 412574090@163.com, sudipm.mukherjee@gmail.com
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
xiongxin@kylinos.cn, weiyufeng <weiyufeng@kylinos.cn>
Subject: Re: [PATCH 2/4] parport: change struct parport member to iobase
Date: Sat, 26 Oct 2024 06:29:37 +0800 [thread overview]
Message-ID: <202410260604.8KzF4khS-lkp@intel.com> (raw)
In-Reply-To: <20241025082128.60034-2-412574090@163.com>
Hi,
kernel test robot noticed the following build errors:
[auto build test ERROR on linus/master]
[also build test ERROR on v6.12-rc4 next-20241025]
[cannot apply to deller-parisc/for-next mkp-scsi/for-next jejb-scsi/for-next tiwai-sound/for-next tiwai-sound/for-linus]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/412574090-163-com/parport-change-struct-parport-member-to-iobase/20241025-162302
base: linus/master
patch link: https://lore.kernel.org/r/20241025082128.60034-2-412574090%40163.com
patch subject: [PATCH 2/4] parport: change struct parport member to iobase
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20241026/202410260604.8KzF4khS-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241026/202410260604.8KzF4khS-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410260604.8KzF4khS-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/ata/pata_parport/pata_parport.c: In function 'pi_init_one':
>> drivers/ata/pata_parport/pata_parport.c:542:29: error: 'struct parport' has no member named 'base'; did you mean 'iobase'?
542 | pi->port = parport->base;
| ^~~~
| iobase
--
In file included from include/linux/device.h:15,
from include/linux/parport.h:16,
from drivers/ata/pata_parport/bpck6.c:16:
drivers/ata/pata_parport/bpck6.c: In function 'bpck6_test_port':
>> drivers/ata/pata_parport/bpck6.c:397:60: error: 'struct parport' has no member named 'base'; did you mean 'iobase'?
397 | pi->pardev->port->modes, pi->pardev->port->base);
| ^~~~
include/linux/dev_printk.h:139:56: note: in definition of macro 'dev_no_printk'
139 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
drivers/ata/pata_parport/bpck6.c:396:9: note: in expansion of macro 'dev_dbg'
396 | dev_dbg(&pi->dev, "PARPORT indicates modes=%x for lp=0x%lx\n",
| ^~~~~~~
vim +542 drivers/ata/pata_parport/pata_parport.c
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 492
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 493 static struct pi_adapter *pi_init_one(struct parport *parport,
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 494 struct pi_protocol *pr, int mode, int unit, int delay)
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 495 {
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 496 struct pardev_cb par_cb = { };
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 497 const struct ata_port_info *ppi[] = { &pata_parport_port_info };
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 498 struct ata_host *host;
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 499 struct pi_adapter *pi;
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 500 struct pi_device_match match = { .parport = parport, .proto = pr };
8844f0aa8dc42f drivers/ata/pata_parport/pata_parport.c Ondrej Zary 2023-02-04 501 int id;
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 502
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 503 /*
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 504 * Abort if there's a device already registered on the same parport
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 505 * using the same protocol.
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 506 */
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 507 if (bus_for_each_dev(&pata_parport_bus_type, NULL, &match, pi_find_dev))
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 508 return NULL;
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 509
5bc9e2d43f8610 drivers/ata/pata_parport/pata_parport.c Ondrej Zary 2023-03-14 510 id = ida_alloc(&pata_parport_bus_dev_ids, GFP_KERNEL);
5bc9e2d43f8610 drivers/ata/pata_parport/pata_parport.c Ondrej Zary 2023-03-14 511 if (id < 0)
5bc9e2d43f8610 drivers/ata/pata_parport/pata_parport.c Ondrej Zary 2023-03-14 512 return NULL;
5bc9e2d43f8610 drivers/ata/pata_parport/pata_parport.c Ondrej Zary 2023-03-14 513
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 514 pi = kzalloc(sizeof(struct pi_adapter), GFP_KERNEL);
5bc9e2d43f8610 drivers/ata/pata_parport/pata_parport.c Ondrej Zary 2023-03-14 515 if (!pi) {
5bc9e2d43f8610 drivers/ata/pata_parport/pata_parport.c Ondrej Zary 2023-03-14 516 ida_free(&pata_parport_bus_dev_ids, id);
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 517 return NULL;
5bc9e2d43f8610 drivers/ata/pata_parport/pata_parport.c Ondrej Zary 2023-03-14 518 }
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 519
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 520 /* set up pi->dev before pi_probe_unit() so it can use dev_printk() */
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 521 pi->dev.parent = &pata_parport_bus;
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 522 pi->dev.bus = &pata_parport_bus_type;
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 523 pi->dev.driver = &pr->driver;
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 524 pi->dev.release = pata_parport_dev_release;
8844f0aa8dc42f drivers/ata/pata_parport/pata_parport.c Ondrej Zary 2023-02-04 525 pi->dev.id = id;
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 526 dev_set_name(&pi->dev, "pata_parport.%u", pi->dev.id);
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 527 if (device_register(&pi->dev)) {
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 528 put_device(&pi->dev);
5bc9e2d43f8610 drivers/ata/pata_parport/pata_parport.c Ondrej Zary 2023-03-14 529 /* pata_parport_dev_release will do ida_free(dev->id) and kfree(pi) */
5bc9e2d43f8610 drivers/ata/pata_parport/pata_parport.c Ondrej Zary 2023-03-14 530 return NULL;
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 531 }
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 532
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 533 pi->proto = pr;
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 534
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 535 if (!try_module_get(pi->proto->owner))
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 536 goto out_unreg_dev;
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 537 if (pi->proto->init_proto && pi->proto->init_proto(pi) < 0)
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 538 goto out_module_put;
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 539
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 540 pi->delay = (delay == -1) ? pi->proto->default_delay : delay;
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 541 pi->mode = mode;
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 @542 pi->port = parport->base;
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 543
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 544 par_cb.private = pi;
5bc9e2d43f8610 drivers/ata/pata_parport/pata_parport.c Ondrej Zary 2023-03-14 545 pi->pardev = parport_register_dev_model(parport, DRV_NAME, &par_cb, id);
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 546 if (!pi->pardev)
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 547 goto out_module_put;
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 548
b42251a867a985 drivers/ata/pata_parport/pata_parport.c Ondrej Zary 2023-02-18 549 if (!pi_probe_unit(pi, unit)) {
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 550 dev_info(&pi->dev, "Adapter not found\n");
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 551 goto out_unreg_parport;
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 552 }
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 553
5b77db9ccff444 drivers/ata/pata_parport/pata_parport.c Ondrej Zary 2023-02-18 554 pi->proto->log_adapter(pi);
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 555
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 556 host = ata_host_alloc_pinfo(&pi->pardev->dev, ppi, 1);
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 557 if (!host)
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 558 goto out_unreg_parport;
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 559 dev_set_drvdata(&pi->dev, host);
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 560 host->private_data = pi;
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 561
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 562 ata_port_desc(host->ports[0], "port %s", pi->pardev->port->name);
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 563 ata_port_desc(host->ports[0], "protocol %s", pi->proto->name);
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 564
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 565 pi_connect(pi);
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 566 if (ata_host_activate(host, 0, NULL, 0, &pata_parport_sht))
dc472c7612297f drivers/ata/pata_parport/pata_parport.c Ondrej Zary 2023-03-11 567 goto out_disconnect;
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 568
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 569 return pi;
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 570
dc472c7612297f drivers/ata/pata_parport/pata_parport.c Ondrej Zary 2023-03-11 571 out_disconnect:
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 572 pi_disconnect(pi);
dc472c7612297f drivers/ata/pata_parport/pata_parport.c Ondrej Zary 2023-03-11 573 out_unreg_parport:
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 574 parport_unregister_device(pi->pardev);
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 575 if (pi->proto->release_proto)
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 576 pi->proto->release_proto(pi);
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 577 out_module_put:
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 578 module_put(pi->proto->owner);
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 579 out_unreg_dev:
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 580 device_unregister(&pi->dev);
5bc9e2d43f8610 drivers/ata/pata_parport/pata_parport.c Ondrej Zary 2023-03-14 581 /* pata_parport_dev_release will do ida_free(dev->id) and kfree(pi) */
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 582 return NULL;
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 583 }
246a1c4c6b7ffb drivers/ata/pata_parport.c Ondrej Zary 2023-01-23 584
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-10-25 22:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 8:21 [PATCH 1/4] parport: use standard kernel printing functions 412574090
2024-10-25 8:21 ` [PATCH 2/4] parport: change struct parport member to iobase 412574090
2024-10-25 21:58 ` kernel test robot
2024-10-25 22:29 ` kernel test robot [this message]
2024-10-25 8:21 ` [PATCH 3/4] parport: add parport_data struct 412574090
2024-10-25 8:21 ` [PATCH 4/4] parport: add iomem type for parport 412574090
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202410260604.8KzF4khS-lkp@intel.com \
--to=lkp@intel.com \
--cc=412574090@163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=weiyufeng@kylinos.cn \
--cc=xiongxin@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.