From: "Sicelo A. Mhlongo" <absicsz@gmail.com>
To: ofono@lists.linux.dev
Cc: "Sicelo A. Mhlongo" <absicsz@gmail.com>
Subject: [PATCH] udevng: restore support for phonet modems
Date: Sat, 26 Oct 2024 13:53:11 +0200 [thread overview]
Message-ID: <20241026115324.211317-1-absicsz@gmail.com> (raw)
Commit 296347f8a4f1 ("udevng: Detect embedded qmi QRTR modems") introduced
a constraint that only rmnet_* modems are valid "net" subsystem devices, thus
breaking phonet modems, which are located in that subsystem as well.
P: /devices/platform/68000000.ocp/48058000.ssi-controller/ssi0/port0/ssi-protocol/net/phonet0
E: DEVPATH=/devices/platform/68000000.ocp/48058000.ssi-controller/ssi0/port0/ssi-protocol/net/phonet0
E: INTERFACE=phonet0
E: OFONO_DRIVER=n900
E: OFONO_ISI_ADDRESS=108
E: SUBSYSTEM=net
Fix the regression by specifically checking for phonet inside
check_net_device().
Fixes: 296347f8a4f1 ("udevng: Detect embedded qmi QRTR modems")
---
plugins/udevng.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/plugins/udevng.c b/plugins/udevng.c
index f4266f39..f34cdcb7 100644
--- a/plugins/udevng.c
+++ b/plugins/udevng.c
@@ -2455,6 +2455,10 @@ static void check_net_device(struct udev_device *device)
}
name = udev_device_get_sysname(device);
+ if (l_str_has_prefix(name, "phonet")) {
+ add_serial_device(device);
+ return;
+ }
if (!l_str_has_prefix(name, "rmnet_"))
return;
--
2.45.2
next reply other threads:[~2024-10-26 11:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-26 11:53 Sicelo A. Mhlongo [this message]
2024-10-28 18:30 ` [PATCH] udevng: restore support for phonet modems patchwork-bot+ofono
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241026115324.211317-1-absicsz@gmail.com \
--to=absicsz@gmail.com \
--cc=ofono@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.