From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CFEB1D6DBF; Sat, 26 Oct 2024 12:54:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729947250; cv=none; b=SDdLwB7oyYIf3XhehYVWm9NpuF2duFYGBBXhaZavOdNPDp9V5K1ESiX7YmiaOobWN7zAhbkHI1EAeNcaObgWbEP6xJQmrWj/YU2nE1+3F2s76f46uzWLdG9j69rjoIsA8N000wmq00nx5jPGC8535pk94sD/VKNGrhslzqLmZlI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729947250; c=relaxed/simple; bh=ewTQi8vvMjY2tDN+rwCGUkIKwCDc2H1+fYWUrCoOJYU=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=ncgHk06cV58p4AnL3/HjEa+igmtDt+/svlXR3F6KY9YA5UVtyXu6J1gYmo4njYAwX9EaFIGMKo45A+5zvVYdCOifw2IU7B+mT1HPTQHOCPNoaZ+ejhtz2IkOsiKiZ1huYPy2tLWIgDGsr7qX7txFrqbTp8OZxL6fTe/3TyBNk/o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WbAamJzl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WbAamJzl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CAC0C4CEC6; Sat, 26 Oct 2024 12:54:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729947249; bh=ewTQi8vvMjY2tDN+rwCGUkIKwCDc2H1+fYWUrCoOJYU=; h=From:To:Subject:Date:In-Reply-To:References:From; b=WbAamJzlwTxPsjFngruaSdwNUN8no6/j4LEN5OV4dI/QGgP/6trmtHB3MO+Zvmjsw 8froMnzAAN+MGW+Tx65nSRHajrYxCHL+sG/EpvlUSG9+KTvDONQtLqJBzhKnQU5Qp8 fco5pc+WYDFq/9afUOsapsPzVlJ39aywhnrVX/w94J6krs5ELKACKwbsL6y29AMyJo XbtP5ym70corM9xx9gJoy3zbbJGNlMgrtYY4I67x/vgGqs7DZg1qJLhLFG7afLdJFP GXahRnyftxP7M8goAMPSD3m/7ehtyiolzjvOklrfB0eCYtlebr5J3tvjTO81ulzdOt Xi0kjKXwh634Q== From: Puranjay Mohan To: Albert Ou , Alexei Starovoitov , Andrew Morton , Andrii Nakryiko , bpf@vger.kernel.org, Daniel Borkmann , "David S. Miller" , Eduard Zingerman , Eric Dumazet , Hao Luo , Helge Deller , Jakub Kicinski , "James E.J. Bottomley" , Jiri Olsa , John Fastabend , KP Singh , linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, Martin KaFai Lau , Mykola Lysenko , netdev@vger.kernel.org, Palmer Dabbelt , Paolo Abeni , Paul Walmsley , Puranjay Mohan , Puranjay Mohan , Shuah Khan , Song Liu , Stanislav Fomichev , Yonghong Song Subject: [PATCH bpf-next v3 1/4] net: checksum: move from32to16() to generic header Date: Sat, 26 Oct 2024 12:53:36 +0000 Message-Id: <20241026125339.26459-2-puranjay@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20241026125339.26459-1-puranjay@kernel.org> References: <20241026125339.26459-1-puranjay@kernel.org> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit from32to16() is used by lib/checksum.c and also by arch/parisc/lib/checksum.c. The next patch will use it in the bpf_csum_diff helper. Move from32to16() to the include/net/checksum.h as csum_from32to16() and remove other implementations. Signed-off-by: Puranjay Mohan Acked-by: Daniel Borkmann Reviewed-by: Toke Høiland-Jørgensen --- arch/parisc/lib/checksum.c | 13 ++----------- include/net/checksum.h | 6 ++++++ lib/checksum.c | 11 +---------- 3 files changed, 9 insertions(+), 21 deletions(-) diff --git a/arch/parisc/lib/checksum.c b/arch/parisc/lib/checksum.c index 4818f3db84a5c..59d8c15d81bd0 100644 --- a/arch/parisc/lib/checksum.c +++ b/arch/parisc/lib/checksum.c @@ -25,15 +25,6 @@ : "=r"(_t) \ : "r"(_r), "0"(_t)); -static inline unsigned short from32to16(unsigned int x) -{ - /* 32 bits --> 16 bits + carry */ - x = (x & 0xffff) + (x >> 16); - /* 16 bits + carry --> 16 bits including carry */ - x = (x & 0xffff) + (x >> 16); - return (unsigned short)x; -} - static inline unsigned int do_csum(const unsigned char * buff, int len) { int odd, count; @@ -85,7 +76,7 @@ static inline unsigned int do_csum(const unsigned char * buff, int len) } if (len & 1) result += le16_to_cpu(*buff); - result = from32to16(result); + result = csum_from32to16(result); if (odd) result = swab16(result); out: @@ -102,7 +93,7 @@ __wsum csum_partial(const void *buff, int len, __wsum sum) { unsigned int result = do_csum(buff, len); addc(result, sum); - return (__force __wsum)from32to16(result); + return (__force __wsum)csum_from32to16(result); } EXPORT_SYMBOL(csum_partial); diff --git a/include/net/checksum.h b/include/net/checksum.h index 1338cb92c8e72..243f972267b8d 100644 --- a/include/net/checksum.h +++ b/include/net/checksum.h @@ -151,6 +151,12 @@ static inline void csum_replace(__wsum *csum, __wsum old, __wsum new) *csum = csum_add(csum_sub(*csum, old), new); } +static inline unsigned short csum_from32to16(unsigned int sum) +{ + sum += (sum >> 16) | (sum << 16); + return (unsigned short)(sum >> 16); +} + struct sk_buff; void inet_proto_csum_replace4(__sum16 *sum, struct sk_buff *skb, __be32 from, __be32 to, bool pseudohdr); diff --git a/lib/checksum.c b/lib/checksum.c index 6860d6b05a171..025ba546e1ec6 100644 --- a/lib/checksum.c +++ b/lib/checksum.c @@ -34,15 +34,6 @@ #include #ifndef do_csum -static inline unsigned short from32to16(unsigned int x) -{ - /* add up 16-bit and 16-bit for 16+c bit */ - x = (x & 0xffff) + (x >> 16); - /* add up carry.. */ - x = (x & 0xffff) + (x >> 16); - return x; -} - static unsigned int do_csum(const unsigned char *buff, int len) { int odd; @@ -90,7 +81,7 @@ static unsigned int do_csum(const unsigned char *buff, int len) #else result += (*buff << 8); #endif - result = from32to16(result); + result = csum_from32to16(result); if (odd) result = ((result >> 8) & 0xff) | ((result & 0xff) << 8); out: -- 2.40.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63714D10BF7 for ; Sat, 26 Oct 2024 12:54:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UHly+E3Ph5esk3+turWSnErHneeXQT8uR3E2q6I+lVo=; b=vqrer0qOZnYmJk 0aTkd+5qmmC8G/mxnTzoL4ls8WodqI2EpRX3np6axM/jCJL9wjLXaN6TJtqQaYDXp1JAi0zT7wMOa fco61DKf0xyRs0l9Mj3Nd52xeaKci60Tmt+AB6kgmHHeXU2m3Ly2B0KkSoxJFgm7SWcTHjsieiRAe RGPI7jNbXAOgmL4Pff+Ott+Kjw/C2OsJwvfGhLYjSEuCHEiKgqLfnBC/zA5c7nlnWMnjG6rmY8VvF hi3bvpilEqrO6F4whihSt3x/LVJaiUU7rs3Q9KKYu+rn/m66Sc2Ca3hJEpzWquOPTuJq1NSIlxfiu edoSqIHHd83TJS4nBPQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t4gJ3-00000006eGE-0lHz; Sat, 26 Oct 2024 12:54:13 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t4gJ0-00000006eFR-1uuT for linux-riscv@lists.infradead.org; Sat, 26 Oct 2024 12:54:11 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id CFD785C5589; Sat, 26 Oct 2024 12:53:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CAC0C4CEC6; Sat, 26 Oct 2024 12:54:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729947249; bh=ewTQi8vvMjY2tDN+rwCGUkIKwCDc2H1+fYWUrCoOJYU=; h=From:To:Subject:Date:In-Reply-To:References:From; b=WbAamJzlwTxPsjFngruaSdwNUN8no6/j4LEN5OV4dI/QGgP/6trmtHB3MO+Zvmjsw 8froMnzAAN+MGW+Tx65nSRHajrYxCHL+sG/EpvlUSG9+KTvDONQtLqJBzhKnQU5Qp8 fco5pc+WYDFq/9afUOsapsPzVlJ39aywhnrVX/w94J6krs5ELKACKwbsL6y29AMyJo XbtP5ym70corM9xx9gJoy3zbbJGNlMgrtYY4I67x/vgGqs7DZg1qJLhLFG7afLdJFP GXahRnyftxP7M8goAMPSD3m/7ehtyiolzjvOklrfB0eCYtlebr5J3tvjTO81ulzdOt Xi0kjKXwh634Q== From: Puranjay Mohan To: Albert Ou , Alexei Starovoitov , Andrew Morton , Andrii Nakryiko , bpf@vger.kernel.org, Daniel Borkmann , "David S. Miller" , Eduard Zingerman , Eric Dumazet , Hao Luo , Helge Deller , Jakub Kicinski , "James E.J. Bottomley" , Jiri Olsa , John Fastabend , KP Singh , linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, Martin KaFai Lau , Mykola Lysenko , netdev@vger.kernel.org, Palmer Dabbelt , Paolo Abeni , Paul Walmsley , Puranjay Mohan , Puranjay Mohan , Shuah Khan , Song Liu , Stanislav Fomichev , Yonghong Song Subject: [PATCH bpf-next v3 1/4] net: checksum: move from32to16() to generic header Date: Sat, 26 Oct 2024 12:53:36 +0000 Message-Id: <20241026125339.26459-2-puranjay@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20241026125339.26459-1-puranjay@kernel.org> References: <20241026125339.26459-1-puranjay@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241026_055410_606304_06B355A4 X-CRM114-Status: GOOD ( 10.93 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org ZnJvbTMydG8xNigpIGlzIHVzZWQgYnkgbGliL2NoZWNrc3VtLmMgYW5kIGFsc28gYnkKYXJjaC9w YXJpc2MvbGliL2NoZWNrc3VtLmMuIFRoZSBuZXh0IHBhdGNoIHdpbGwgdXNlIGl0IGluIHRoZQpi cGZfY3N1bV9kaWZmIGhlbHBlci4KCk1vdmUgZnJvbTMydG8xNigpIHRvIHRoZSBpbmNsdWRlL25l dC9jaGVja3N1bS5oIGFzIGNzdW1fZnJvbTMydG8xNigpIGFuZApyZW1vdmUgb3RoZXIgaW1wbGVt ZW50YXRpb25zLgoKU2lnbmVkLW9mZi1ieTogUHVyYW5qYXkgTW9oYW4gPHB1cmFuamF5QGtlcm5l bC5vcmc+CkFja2VkLWJ5OiBEYW5pZWwgQm9ya21hbm4gPGRhbmllbEBpb2dlYXJib3gubmV0PgpS ZXZpZXdlZC1ieTogVG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIDx0b2tlQHJlZGhhdC5jb20+Ci0t LQogYXJjaC9wYXJpc2MvbGliL2NoZWNrc3VtLmMgfCAxMyArKy0tLS0tLS0tLS0tCiBpbmNsdWRl L25ldC9jaGVja3N1bS5oICAgICB8ICA2ICsrKysrKwogbGliL2NoZWNrc3VtLmMgICAgICAgICAg ICAgfCAxMSArLS0tLS0tLS0tLQogMyBmaWxlcyBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKyksIDIx IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2FyY2gvcGFyaXNjL2xpYi9jaGVja3N1bS5jIGIv YXJjaC9wYXJpc2MvbGliL2NoZWNrc3VtLmMKaW5kZXggNDgxOGYzZGI4NGE1Yy4uNTlkOGMxNWQ4 MWJkMCAxMDA2NDQKLS0tIGEvYXJjaC9wYXJpc2MvbGliL2NoZWNrc3VtLmMKKysrIGIvYXJjaC9w YXJpc2MvbGliL2NoZWNrc3VtLmMKQEAgLTI1LDE1ICsyNSw2IEBACiAJOiAiPXIiKF90KSAgICAg ICAgICAgICAgICAgICAgICBcCiAJOiAiciIoX3IpLCAiMCIoX3QpKTsKIAotc3RhdGljIGlubGlu ZSB1bnNpZ25lZCBzaG9ydCBmcm9tMzJ0bzE2KHVuc2lnbmVkIGludCB4KQotewotCS8qIDMyIGJp dHMgLS0+IDE2IGJpdHMgKyBjYXJyeSAqLwotCXggPSAoeCAmIDB4ZmZmZikgKyAoeCA+PiAxNik7 Ci0JLyogMTYgYml0cyArIGNhcnJ5IC0tPiAxNiBiaXRzIGluY2x1ZGluZyBjYXJyeSAqLwotCXgg PSAoeCAmIDB4ZmZmZikgKyAoeCA+PiAxNik7Ci0JcmV0dXJuICh1bnNpZ25lZCBzaG9ydCl4Owot fQotCiBzdGF0aWMgaW5saW5lIHVuc2lnbmVkIGludCBkb19jc3VtKGNvbnN0IHVuc2lnbmVkIGNo YXIgKiBidWZmLCBpbnQgbGVuKQogewogCWludCBvZGQsIGNvdW50OwpAQCAtODUsNyArNzYsNyBA QCBzdGF0aWMgaW5saW5lIHVuc2lnbmVkIGludCBkb19jc3VtKGNvbnN0IHVuc2lnbmVkIGNoYXIg KiBidWZmLCBpbnQgbGVuKQogCX0KIAlpZiAobGVuICYgMSkKIAkJcmVzdWx0ICs9IGxlMTZfdG9f Y3B1KCpidWZmKTsKLQlyZXN1bHQgPSBmcm9tMzJ0bzE2KHJlc3VsdCk7CisJcmVzdWx0ID0gY3N1 bV9mcm9tMzJ0bzE2KHJlc3VsdCk7CiAJaWYgKG9kZCkKIAkJcmVzdWx0ID0gc3dhYjE2KHJlc3Vs dCk7CiBvdXQ6CkBAIC0xMDIsNyArOTMsNyBAQCBfX3dzdW0gY3N1bV9wYXJ0aWFsKGNvbnN0IHZv aWQgKmJ1ZmYsIGludCBsZW4sIF9fd3N1bSBzdW0pCiB7CiAJdW5zaWduZWQgaW50IHJlc3VsdCA9 IGRvX2NzdW0oYnVmZiwgbGVuKTsKIAlhZGRjKHJlc3VsdCwgc3VtKTsKLQlyZXR1cm4gKF9fZm9y Y2UgX193c3VtKWZyb20zMnRvMTYocmVzdWx0KTsKKwlyZXR1cm4gKF9fZm9yY2UgX193c3VtKWNz dW1fZnJvbTMydG8xNihyZXN1bHQpOwogfQogCiBFWFBPUlRfU1lNQk9MKGNzdW1fcGFydGlhbCk7 CmRpZmYgLS1naXQgYS9pbmNsdWRlL25ldC9jaGVja3N1bS5oIGIvaW5jbHVkZS9uZXQvY2hlY2tz dW0uaAppbmRleCAxMzM4Y2I5MmM4ZTcyLi4yNDNmOTcyMjY3YjhkIDEwMDY0NAotLS0gYS9pbmNs dWRlL25ldC9jaGVja3N1bS5oCisrKyBiL2luY2x1ZGUvbmV0L2NoZWNrc3VtLmgKQEAgLTE1MSw2 ICsxNTEsMTIgQEAgc3RhdGljIGlubGluZSB2b2lkIGNzdW1fcmVwbGFjZShfX3dzdW0gKmNzdW0s IF9fd3N1bSBvbGQsIF9fd3N1bSBuZXcpCiAJKmNzdW0gPSBjc3VtX2FkZChjc3VtX3N1YigqY3N1 bSwgb2xkKSwgbmV3KTsKIH0KIAorc3RhdGljIGlubGluZSB1bnNpZ25lZCBzaG9ydCBjc3VtX2Zy b20zMnRvMTYodW5zaWduZWQgaW50IHN1bSkKK3sKKwlzdW0gKz0gKHN1bSA+PiAxNikgfCAoc3Vt IDw8IDE2KTsKKwlyZXR1cm4gKHVuc2lnbmVkIHNob3J0KShzdW0gPj4gMTYpOworfQorCiBzdHJ1 Y3Qgc2tfYnVmZjsKIHZvaWQgaW5ldF9wcm90b19jc3VtX3JlcGxhY2U0KF9fc3VtMTYgKnN1bSwg c3RydWN0IHNrX2J1ZmYgKnNrYiwKIAkJCSAgICAgIF9fYmUzMiBmcm9tLCBfX2JlMzIgdG8sIGJv b2wgcHNldWRvaGRyKTsKZGlmZiAtLWdpdCBhL2xpYi9jaGVja3N1bS5jIGIvbGliL2NoZWNrc3Vt LmMKaW5kZXggNjg2MGQ2YjA1YTE3MS4uMDI1YmE1NDZlMWVjNiAxMDA2NDQKLS0tIGEvbGliL2No ZWNrc3VtLmMKKysrIGIvbGliL2NoZWNrc3VtLmMKQEAgLTM0LDE1ICszNCw2IEBACiAjaW5jbHVk ZSA8YXNtL2J5dGVvcmRlci5oPgogCiAjaWZuZGVmIGRvX2NzdW0KLXN0YXRpYyBpbmxpbmUgdW5z aWduZWQgc2hvcnQgZnJvbTMydG8xNih1bnNpZ25lZCBpbnQgeCkKLXsKLQkvKiBhZGQgdXAgMTYt Yml0IGFuZCAxNi1iaXQgZm9yIDE2K2MgYml0ICovCi0JeCA9ICh4ICYgMHhmZmZmKSArICh4ID4+ IDE2KTsKLQkvKiBhZGQgdXAgY2FycnkuLiAqLwotCXggPSAoeCAmIDB4ZmZmZikgKyAoeCA+PiAx Nik7Ci0JcmV0dXJuIHg7Ci19Ci0KIHN0YXRpYyB1bnNpZ25lZCBpbnQgZG9fY3N1bShjb25zdCB1 bnNpZ25lZCBjaGFyICpidWZmLCBpbnQgbGVuKQogewogCWludCBvZGQ7CkBAIC05MCw3ICs4MSw3 IEBAIHN0YXRpYyB1bnNpZ25lZCBpbnQgZG9fY3N1bShjb25zdCB1bnNpZ25lZCBjaGFyICpidWZm LCBpbnQgbGVuKQogI2Vsc2UKIAkJcmVzdWx0ICs9ICgqYnVmZiA8PCA4KTsKICNlbmRpZgotCXJl c3VsdCA9IGZyb20zMnRvMTYocmVzdWx0KTsKKwlyZXN1bHQgPSBjc3VtX2Zyb20zMnRvMTYocmVz dWx0KTsKIAlpZiAob2RkKQogCQlyZXN1bHQgPSAoKHJlc3VsdCA+PiA4KSAmIDB4ZmYpIHwgKChy ZXN1bHQgJiAweGZmKSA8PCA4KTsKIG91dDoKLS0gCjIuNDAuMQoKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcgbGlzdAps aW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK