From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB920224CC; Sat, 26 Oct 2024 15:38:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729957083; cv=none; b=u688xSrC7GIhcKK5iTlbjM3dDsV0PFsDzeYfSgMXW5O5AIatlzr1OSEF5enyh6PyIlGqWnawXIZRZ/V1S8yZvOeQIVS4ZTAaQLEMxSE0UoVws6CmTAC4nRMd7xVpDScMxBrDC1b9y/mBr+5cfNLZ7il+gnuiot03b1TqZ4Hu3ow= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729957083; c=relaxed/simple; bh=kfIY95pLBR/QjZ2VU50kuWXzRCaY64hreBQnX/RCywY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rXY7nE/CH81Q0HiOxq4QtcDvFzmPJ9CtHONcYTBEbn32Ekm3RyCTJC+X7kKPkiecQOG9pO1pcnsUKeRaRSgEPV40Qz3CuOaF9Mz7bV+kk3y2Pm3xuK60vqCSwJayPv86p4qqD9+9leY/yNQ5p4mfd+pa+ceJkGnxAX+7E0CTchc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=l4loFfCD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="l4loFfCD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0F5BC4CEC6; Sat, 26 Oct 2024 15:37:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729957082; bh=kfIY95pLBR/QjZ2VU50kuWXzRCaY64hreBQnX/RCywY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l4loFfCDaJRcni7y7zwoZH4ivEXGqEwmWul+6KClw86Um9/PtqHtjzImuR2iSnhlb fpoR853BTYJ41Zl7T27EFEPbLnxt9FZPZ3twhiawjpJuFArX/2cvUZc/LShQ9iqu/q xnqvpJ5f2kD6rFdemk02bAIr9/64ZMF2uag27ubVXiRyayXIqQHm4AKL9Ll1xPHZ6e gzVBspRiUh3XuSjSALbdkxPqxLWN8t63pGvWw8c3HWfYSkydCEEYCnNW2MLh/2YpXi rBn8GyDJ9luZIKLh9vVJ5VInoGuh7AaQgCk6gvBner2zmcisABzvatxnkOFSwZShBq vl8TLYj56+P+g== Date: Sat, 26 Oct 2024 16:37:56 +0100 From: Simon Horman To: Yue Haibing Cc: anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com, maciej.fijalkowski@intel.com, vedang.patel@intel.com, jithu.joseph@intel.com, andre.guedes@intel.com, jacob.e.keller@intel.com, sven.auhagen@voleatech.de, alexander.h.duyck@intel.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH v4 net-next 3/4] ixgbe: Fix passing 0 to ERR_PTR in ixgbe_run_xdp() Message-ID: <20241026153756.GM1507976@kernel.org> References: <20241026041249.1267664-1-yuehaibing@huawei.com> <20241026041249.1267664-4-yuehaibing@huawei.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241026041249.1267664-4-yuehaibing@huawei.com> On Sat, Oct 26, 2024 at 12:12:48PM +0800, Yue Haibing wrote: > ixgbe_run_xdp() converts customed xdp action to a negative error code > with the sk_buff pointer type which be checked with IS_ERR in > ixgbe_clean_rx_irq(). Remove this error pointer handing instead use > plain int return value. > > Fixes: 924708081629 ("ixgbe: add XDP support for pass and drop actions") > Reviewed-by: Jacob Keller > Reviewed-by: Maciej Fijalkowski > Signed-off-by: Yue Haibing Reviewed-by: Simon Horman From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACC97D0C604 for ; Sat, 26 Oct 2024 15:38:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 75A1E812F6; Sat, 26 Oct 2024 15:38:07 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id edet6ZGCO-Me; Sat, 26 Oct 2024 15:38:07 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org AA966812C3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1729957086; bh=Vxn+LZ4pnA2ForOyFeBAWcXhqjDmr8BMWQeDzXfeQDI=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=VboJJ/bMwXkDoadXX3LxkYOkXvvUXsnE3Py+Fo5K/fikfANci7HG5w9kqBWRr4IzV 8EkTTtGTmJKm4YfjneCt6wE+WVGs4PhL6u7KOWsiwYLU8F9A0REFkn8WY6xyuk8iI8 NP0/vvBaQV+wnHD2OEvMzWZ8qPF2BDf1y02KjnMVWyHivyF1vHLXjcf8x4bekPza6N diyub3vfRZvoW68z14OU3eg0cDTbD98wZ3ZnhS9VXHBa+sNRR6lwPDh1EMRdwqXVDy Ruze9a2oWEzQbaL1EQPblOJYSOX2otdnB5sDqHfy4QFHWiGz5q1jLenYmDaHZiJiXs GlFRRFzice28A== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id AA966812C3; Sat, 26 Oct 2024 15:38:06 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists1.osuosl.org (Postfix) with ESMTP id 125F85C1E for ; Sat, 26 Oct 2024 15:38:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id E2CE06062C for ; Sat, 26 Oct 2024 15:38:04 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id UKbghJpaO46g for ; Sat, 26 Oct 2024 15:38:04 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=147.75.193.91; helo=nyc.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 21A21605D8 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 21A21605D8 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by smtp3.osuosl.org (Postfix) with ESMTPS id 21A21605D8 for ; Sat, 26 Oct 2024 15:38:04 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 9C494A401E6; Sat, 26 Oct 2024 15:36:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0F5BC4CEC6; Sat, 26 Oct 2024 15:37:58 +0000 (UTC) Date: Sat, 26 Oct 2024 16:37:56 +0100 From: Simon Horman To: Yue Haibing Message-ID: <20241026153756.GM1507976@kernel.org> References: <20241026041249.1267664-1-yuehaibing@huawei.com> <20241026041249.1267664-4-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241026041249.1267664-4-yuehaibing@huawei.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729957082; bh=kfIY95pLBR/QjZ2VU50kuWXzRCaY64hreBQnX/RCywY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l4loFfCDaJRcni7y7zwoZH4ivEXGqEwmWul+6KClw86Um9/PtqHtjzImuR2iSnhlb fpoR853BTYJ41Zl7T27EFEPbLnxt9FZPZ3twhiawjpJuFArX/2cvUZc/LShQ9iqu/q xnqvpJ5f2kD6rFdemk02bAIr9/64ZMF2uag27ubVXiRyayXIqQHm4AKL9Ll1xPHZ6e gzVBspRiUh3XuSjSALbdkxPqxLWN8t63pGvWw8c3HWfYSkydCEEYCnNW2MLh/2YpXi rBn8GyDJ9luZIKLh9vVJ5VInoGuh7AaQgCk6gvBner2zmcisABzvatxnkOFSwZShBq vl8TLYj56+P+g== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=l4loFfCD Subject: Re: [Intel-wired-lan] [PATCH v4 net-next 3/4] ixgbe: Fix passing 0 to ERR_PTR in ixgbe_run_xdp() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexander.h.duyck@intel.com, andre.guedes@intel.com, maciej.fijalkowski@intel.com, hawk@kernel.org, daniel@iogearbox.net, jithu.joseph@intel.com, przemyslaw.kitszel@intel.com, john.fastabend@gmail.com, ast@kernel.org, linux-kernel@vger.kernel.org, edumazet@google.com, netdev@vger.kernel.org, anthony.l.nguyen@intel.com, intel-wired-lan@lists.osuosl.org, jacob.e.keller@intel.com, kuba@kernel.org, bpf@vger.kernel.org, pabeni@redhat.com, davem@davemloft.net, vedang.patel@intel.com Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Sat, Oct 26, 2024 at 12:12:48PM +0800, Yue Haibing wrote: > ixgbe_run_xdp() converts customed xdp action to a negative error code > with the sk_buff pointer type which be checked with IS_ERR in > ixgbe_clean_rx_irq(). Remove this error pointer handing instead use > plain int return value. > > Fixes: 924708081629 ("ixgbe: add XDP support for pass and drop actions") > Reviewed-by: Jacob Keller > Reviewed-by: Maciej Fijalkowski > Signed-off-by: Yue Haibing Reviewed-by: Simon Horman