All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Thomas Perale via buildroot <buildroot@buildroot.org>
Cc: Thomas Perale <thomas.perale@mind.be>,
	Joeri Barbarien <joeri.barbarien@nokia.com>
Subject: Re: [Buildroot] [PATCH 1/1] package/popperjs: remove PopperJS package
Date: Sat, 26 Oct 2024 16:52:51 +0200	[thread overview]
Message-ID: <20241026165251.437c67bb@windsurf> (raw)
In-Reply-To: <20240918151043.907458-1-thomas.perale@mind.be>

Hello Thomas,

I have applied, after doing some small tweaks.

First, commit title:

	package/popperjs: remove package

(no need to repeat the package name)

On Wed, 18 Sep 2024 17:10:43 +0200
Thomas Perale via buildroot <buildroot@buildroot.org> wrote:

> PopperJS project is now called floating-ui and is hosted on
> https://github.com/floating-ui/floating-ui this caused legacy
> source code archives to be repackaged with difference directory
> name which broke the sha256 hash and made the autobuild fail.
> 
> Given the package has never been bumped since its introduction the
> support for that package should probably be dropped.

I added here an indication that the person who contributed/maintained
this package dropped himself from the DEVELOPERS file in March 2024.
Which means the package was basically orphan since then.


> +config BR2_PACKAGE_POPPERJS
> +	string "PopperJS has been removed"

This should have been a "bool", not a "string".

And it should have had:

	select BR2_LEGACY

Applied with those fixes. Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2024-10-26 14:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-18 15:10 [Buildroot] [PATCH 1/1] package/popperjs: remove PopperJS package Thomas Perale via buildroot
2024-10-26 14:52 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241026165251.437c67bb@windsurf \
    --to=buildroot@buildroot.org \
    --cc=joeri.barbarien@nokia.com \
    --cc=thomas.perale@mind.be \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.