All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Andreas Düring via buildroot" <buildroot@buildroot.org>
Cc: "Fabrice Fontaine" <fontaine.fabrice@gmail.com>,
	"Andreas Düring" <brpi@duering-andreas.de>
Subject: Re: [Buildroot] [PATCH v1 1/1] package/mbedtls: Move test binaries to subdirectory
Date: Sat, 26 Oct 2024 17:50:21 +0200	[thread overview]
Message-ID: <20241026175021.4921fd10@windsurf> (raw)
In-Reply-To: <20240916170340.13019-1-brpi@duering-andreas.de>

Hello Andreas,

On Mon, 16 Sep 2024 19:03:40 +0200
Andreas Düring via buildroot <buildroot@buildroot.org> wrote:

> The mbedtls package has a config option BR2_PACKAGE_MBEDTLS_PROGRAMS,
> which enables some test programs to be built and installed.
> However, some of the test programs have unfortunate names,
> e.g. "hello" and "strerror", which may lead to name collisions (?)
> and also otherwise "pollute" /usr/bin/.
> 
> Add a patch to the CMakeLists.txt files, so that the binaries go
> to /usr/bin/mbedtls.
> 
> Signed-off-by: Andreas Düring <brpi@duering-andreas.de>

Thanks a lot for raising this issue, and proposing this patch.

However, as Arnout has pointed out, we need the patch to be submitted
upstream, and an "Upstream:" tag with the reference to the upstream
submission (email, pull request, etc.).

In addition, why would programs go in /usr/bin/mbedtls? Isn't the right
course action to rename those programs so that they don't have
conflicting names? Like mbedtls-hello, mbedtls-strerror, etc. ?

This is really something to take and discuss with upstream.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2024-10-26 15:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-16 17:03 [Buildroot] [PATCH v1 1/1] package/mbedtls: Move test binaries to subdirectory Andreas Düring via buildroot
2024-10-26 15:50 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241026175021.4921fd10@windsurf \
    --to=buildroot@buildroot.org \
    --cc=brpi@duering-andreas.de \
    --cc=fontaine.fabrice@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.