From: kernel test robot <lkp@intel.com>
To: Shakeel Butt <shakeel.butt@linux.dev>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH v2] memcg: workingset: remove folio_memcg_rcu usage
Date: Sun, 27 Oct 2024 13:09:15 +0800 [thread overview]
Message-ID: <202410271316.RPNBjlOR-lkp@intel.com> (raw)
In-Reply-To: <20241026163707.2479526-1-shakeel.butt@linux.dev>
Hi Shakeel,
kernel test robot noticed the following build errors:
[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on linus/master v6.12-rc4 next-20241025]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Shakeel-Butt/memcg-workingset-remove-folio_memcg_rcu-usage/20241027-003815
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20241026163707.2479526-1-shakeel.butt%40linux.dev
patch subject: [PATCH v2] memcg: workingset: remove folio_memcg_rcu usage
config: sh-secureedge5410_defconfig (https://download.01.org/0day-ci/archive/20241027/202410271316.RPNBjlOR-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241027/202410271316.RPNBjlOR-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410271316.RPNBjlOR-lkp@intel.com/
All errors (new ones prefixed by >>):
mm/workingset.c: In function 'workingset_activation':
>> mm/workingset.c:598:38: error: implicit declaration of function 'folio_memcg_charged'; did you mean 'folio_memcg_check'? [-Werror=implicit-function-declaration]
598 | if (mem_cgroup_disabled() || folio_memcg_charged(folio))
| ^~~~~~~~~~~~~~~~~~~
| folio_memcg_check
cc1: some warnings being treated as errors
vim +598 mm/workingset.c
587
588 /**
589 * workingset_activation - note a page activation
590 * @folio: Folio that is being activated.
591 */
592 void workingset_activation(struct folio *folio)
593 {
594 /*
595 * Filter non-memcg pages here, e.g. unmap can call
596 * mark_page_accessed() on VDSO pages.
597 */
> 598 if (mem_cgroup_disabled() || folio_memcg_charged(folio))
599 workingset_age_nonresident(folio_lruvec(folio), folio_nr_pages(folio));
600 }
601
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-10-27 5:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-26 16:37 [PATCH v2] memcg: workingset: remove folio_memcg_rcu usage Shakeel Butt
2024-10-27 5:09 ` kernel test robot
2024-10-27 5:09 ` kernel test robot [this message]
2024-10-27 6:55 ` Shakeel Butt
2024-10-27 17:33 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202410271316.RPNBjlOR-lkp@intel.com \
--to=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=shakeel.butt@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.