All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: "Hans de Goede" <hdegoede@redhat.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
	"Len Brown" <lenb@kernel.org>,
	"Maximilian Luz" <luzmaximilian@gmail.com>,
	"Lee Chun-Yi" <jlee@suse.com>,
	"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
	"Corentin Chary" <corentin.chary@gmail.com>,
	"Luke D . Jones" <luke@ljones.dev>,
	"Ike Panhc" <ike.pan@canonical.com>,
	"Henrique de Moraes Holschuh" <hmh@hmh.eng.br>,
	"Alexis Belmonte" <alexbelm48@gmail.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Ai Chao" <aichao@kylinos.cn>, "Gergo Koteles" <soyer@irl.hu>,
	"open list" <linux-kernel@vger.kernel.org>,
	"open list:ACPI" <linux-acpi@vger.kernel.org>,
	"open list:MICROSOFT SURFACE PLATFORM PROFILE DRIVER"
	<platform-driver-x86@vger.kernel.org>,
	"open list:THINKPAD ACPI EXTRAS DRIVER"
	<ibm-acpi-devel@lists.sourceforge.net>,
	"Mark Pearson" <mpearson-lenovo@squebb.ca>,
	"Matthew Schwartz" <matthew.schwartz@linux.dev>,
	"Mario Limonciello" <mario.limonciello@amd.com>
Subject: [PATCH v2 05/15] ACPI: platform_profile: Move sanity check out of the mutex
Date: Sun, 27 Oct 2024 21:01:21 -0500	[thread overview]
Message-ID: <20241028020131.8031-6-mario.limonciello@amd.com> (raw)
In-Reply-To: <20241028020131.8031-1-mario.limonciello@amd.com>

The sanity check that the platform handler had choices set doesn't
need the mutex taken.  Move it to earlier in the registration.

Tested-by: Matthew Schwartz <matthew.schwartz@linux.dev>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 drivers/acpi/platform_profile.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
index 0c60fc970b6e8..c20256bb39579 100644
--- a/drivers/acpi/platform_profile.c
+++ b/drivers/acpi/platform_profile.c
@@ -180,6 +180,12 @@ int platform_profile_register(struct platform_profile_handler *pprof)
 {
 	int err;
 
+	/* Sanity check the profile handler field are set */
+	if (!pprof || bitmap_empty(pprof->choices, PLATFORM_PROFILE_LAST) ||
+		!pprof->profile_set || !pprof->profile_get) {
+		return -EINVAL;
+	}
+
 	mutex_lock(&profile_lock);
 	/* We can only have one active profile */
 	if (cur_profile) {
@@ -187,13 +193,6 @@ int platform_profile_register(struct platform_profile_handler *pprof)
 		return -EEXIST;
 	}
 
-	/* Sanity check the profile handler field are set */
-	if (!pprof || bitmap_empty(pprof->choices, PLATFORM_PROFILE_LAST) ||
-		!pprof->profile_set || !pprof->profile_get) {
-		mutex_unlock(&profile_lock);
-		return -EINVAL;
-	}
-
 	err = sysfs_create_group(acpi_kobj, &platform_profile_group);
 	if (err) {
 		mutex_unlock(&profile_lock);
-- 
2.43.0


  parent reply	other threads:[~2024-10-28  2:02 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-28  2:01 [PATCH v2 00/15] Add support for binding ACPI platform profile to multiple drivers Mario Limonciello
2024-10-28  2:01 ` [PATCH v2 01/15] ACPI: platform-profile: Add a name member to handlers Mario Limonciello
2024-10-28 17:27   ` Maximilian Luz
2024-10-28  2:01 ` [PATCH v2 02/15] platform/surface: aggregator: Add platform handler pointer to device Mario Limonciello
2024-10-28 17:30   ` Maximilian Luz
2024-10-28 17:37     ` Mario Limonciello
2024-10-28  2:01 ` [PATCH v2 03/15] ACPI: platform_profile: Add platform handler argument to platform_profile_remove() Mario Limonciello
2024-10-28 17:31   ` Maximilian Luz
2024-10-28  2:01 ` [PATCH v2 04/15] ACPI: platform_profile: Add a list to platform profile handler Mario Limonciello
2024-10-28  2:01 ` Mario Limonciello [this message]
2024-10-29 10:12   ` [PATCH v2 05/15] ACPI: platform_profile: Move sanity check out of the mutex Ilpo Järvinen
2024-10-29 16:31     ` Mario Limonciello
2024-10-28  2:01 ` [PATCH v2 06/15] ACPI: platform_profile: Use guard(mutex) for register/unregister Mario Limonciello
2024-10-28  2:01 ` [PATCH v2 07/15] ACPI: platform_profile: Only remove group when no more handler registered Mario Limonciello
2024-10-28  2:01 ` [PATCH v2 08/15] ACPI: platform_profile: Require handlers to support balanced profile Mario Limonciello
2024-10-28  2:01 ` [PATCH v2 09/15] ACPI: platform_profile: Notify change events on register and unregister Mario Limonciello
2024-10-28  2:01 ` [PATCH v2 10/15] ACPI: platform_profile: Only show profiles common for all handlers Mario Limonciello
2024-10-29 10:19   ` Ilpo Järvinen
2024-10-28  2:01 ` [PATCH v2 11/15] ACPI: platform_profile: Set profile for all registered handlers Mario Limonciello
2024-10-29 10:22   ` Ilpo Järvinen
2024-10-29 16:36     ` Mario Limonciello
2024-10-29 16:50       ` Ilpo Järvinen
2024-10-29 16:51         ` Mario Limonciello
2024-10-28  2:01 ` [PATCH v2 12/15] ACPI: platform_profile: Make sure all profile handlers agree on profile Mario Limonciello
2024-10-29 10:43   ` Ilpo Järvinen
2024-10-28  2:01 ` [PATCH v2 13/15] ACPI: platform_profile: Check all profile handler to calculate next Mario Limonciello
2024-10-28  2:01 ` [PATCH v2 14/15] ACPI: platform_profile: Allow multiple handlers Mario Limonciello
2024-10-28  2:01 ` [PATCH v2 15/15] platform/x86/amd: pmf: Drop all quirks Mario Limonciello
2024-10-28  3:49   ` Shyam Sundar S K
2024-10-30 13:41 ` [PATCH v2 00/15] Add support for binding ACPI platform profile to multiple drivers Hans de Goede
2024-10-30 14:08   ` Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241028020131.8031-6-mario.limonciello@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=aichao@kylinos.cn \
    --cc=alexbelm48@gmail.com \
    --cc=corentin.chary@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=hmh@hmh.eng.br \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=ike.pan@canonical.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jlee@suse.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke@ljones.dev \
    --cc=luzmaximilian@gmail.com \
    --cc=matthew.schwartz@linux.dev \
    --cc=mpearson-lenovo@squebb.ca \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=soyer@irl.hu \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.