From: Suraj Kandpal <suraj.kandpal@intel.com>
To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: ankit.k.nautiyal@intel.com, matthew.d.roper@intel.com,
Suraj Kandpal <suraj.kandpal@intel.com>,
Arun R Murthy <arun.r.murthy@intel.com>
Subject: [PATCH 1/3] drm/i915/xe3lpd: Increase resolution for plane to support 6k
Date: Mon, 28 Oct 2024 13:13:31 +0530 [thread overview]
Message-ID: <20241028074333.182041-2-suraj.kandpal@intel.com> (raw)
In-Reply-To: <20241028074333.182041-1-suraj.kandpal@intel.com>
DISPLAY_VER >= 30 onwards CRTC can now support 6k resolution.
Increase pipe and plane max width and height to reflect this
increase in resolution.
--v2
-Take care of the subsampling scenario sooner rather than later [Matt]
--v3
-Take care of the joined pipe limits too [Ankit/Matt]
--v4
-Leave the joiner limits check here as is and handle them later [Ville]
Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
drivers/gpu/drm/i915/display/intel_display.c | 5 ++++-
.../gpu/drm/i915/display/skl_universal_plane.c | 16 +++++++++++++++-
2 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index ef1436146325..92e22bf53e76 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -8450,7 +8450,10 @@ intel_mode_valid_max_plane_size(struct drm_i915_private *dev_priv,
* plane so let's not advertize modes that are
* too big for that.
*/
- if (DISPLAY_VER(dev_priv) >= 11) {
+ if (DISPLAY_VER(dev_priv) >= 30) {
+ plane_width_max = 6144 * num_joined_pipes;
+ plane_height_max = 4800;
+ } else if (DISPLAY_VER(dev_priv) >= 11) {
plane_width_max = 5120 * num_joined_pipes;
plane_height_max = 4320;
} else {
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index a0a7ed01415a..29e52af5f206 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -431,6 +431,16 @@ static int icl_plane_min_width(const struct drm_framebuffer *fb,
}
}
+static int xe3_plane_max_width(const struct drm_framebuffer *fb,
+ int color_plane,
+ unsigned int rotation)
+{
+ if (intel_format_info_is_yuv_semiplanar(fb->format, fb->modifier))
+ return 4096;
+ else
+ return 6144;
+}
+
static int icl_hdr_plane_max_width(const struct drm_framebuffer *fb,
int color_plane,
unsigned int rotation)
@@ -2584,7 +2594,11 @@ skl_universal_plane_create(struct drm_i915_private *dev_priv,
intel_fbc_add_plane(skl_plane_fbc(dev_priv, pipe, plane_id), plane);
- if (DISPLAY_VER(dev_priv) >= 11) {
+ if (DISPLAY_VER(dev_priv) >= 30) {
+ plane->max_width = xe3_plane_max_width;
+ plane->max_height = icl_plane_max_height;
+ plane->min_cdclk = icl_plane_min_cdclk;
+ } else if (DISPLAY_VER(dev_priv) >= 11) {
plane->min_width = icl_plane_min_width;
if (icl_is_hdr_plane(dev_priv, plane_id))
plane->max_width = icl_hdr_plane_max_width;
--
2.34.1
next prev parent reply other threads:[~2024-10-28 7:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 7:43 [PATCH 0/5] Add 6k resolution support for a single CRTC Suraj Kandpal
2024-10-28 7:43 ` Suraj Kandpal [this message]
2024-10-28 7:43 ` [PATCH 2/3] drm/i915/psr: Change psr size limits check Suraj Kandpal
2024-10-28 12:44 ` Nautiyal, Ankit K
2024-10-28 12:54 ` Nautiyal, Ankit K
2024-10-28 13:00 ` Suraj Kandpal
2024-10-28 21:11 ` Matt Roper
2024-10-28 7:43 ` [PATCH 3/3] drm/i914/xe3lpd: Increase bigjoiner limitations Suraj Kandpal
2024-10-28 15:00 ` ✓ CI.Patch_applied: success for Add 6k resolution support for a single CRTC (rev5) Patchwork
2024-10-28 15:00 ` ✓ CI.checkpatch: " Patchwork
2024-10-28 15:02 ` ✓ CI.KUnit: " Patchwork
2024-10-28 15:20 ` ✓ CI.Build: " Patchwork
2024-10-28 15:23 ` ✓ CI.Hooks: " Patchwork
2024-10-28 15:24 ` ✗ CI.checksparse: warning " Patchwork
2024-10-28 16:09 ` ✓ CI.BAT: success " Patchwork
2024-10-28 17:19 ` ✗ CI.FULL: failure " Patchwork
2024-10-29 11:03 ` ✗ Fi.CI.SPARSE: warning " Patchwork
2024-10-29 11:37 ` ✓ Fi.CI.BAT: success " Patchwork
2024-10-29 11:51 ` ✗ CI.FULL: failure " Patchwork
2024-10-29 13:36 ` ✗ Fi.CI.IGT: " Patchwork
2024-10-30 19:31 ` Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028074333.182041-2-suraj.kandpal@intel.com \
--to=suraj.kandpal@intel.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=arun.r.murthy@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.