From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13893D13570 for ; Mon, 28 Oct 2024 11:21:28 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1t5NoL-0002Ja-Kn; Mon, 28 Oct 2024 11:21:26 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1t5NoK-0002JT-By for linux-f2fs-devel@lists.sourceforge.net; Mon, 28 Oct 2024 11:21:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KLtHY9tS67dDZxAwj9pQlA2Bn0F9rB4pbPk7zyiMrFE=; b=DE9/Tdzpvxdie35+fLoAxpFauL EeeYQrFGUF8oqD/y5eYuNhhsoI8EEmbF9WzIdIOZRQqYwStwFvg25e/grXBqhA6sPzlwTgPs7fsFP dEJiYOfQSmozOkL1MCMmW8ds7yzQ3LCRvjKj1EuisouqRs5RJS+Sa0djsY45pLxhxPp8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=KLtHY9tS67dDZxAwj9pQlA2Bn0F9rB4pbPk7zyiMrFE=; b=k JRL/aBH1r8MMd545YkSUOpz6hDtP2rhsI3X8UCdjUxAZ13Ft+biHIPMSIYozIRfvIY6XPMUuskXjg VjgWRmYySdIORV07PaXbgh717wp56CIusNpJtM3g9DHEyqQKtMOogBumEc4NRnlAwcBfMjXjalz4C zATb/rMGsqQu96Us=; Received: from out-174.mta1.migadu.com ([95.215.58.174]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1t5NoJ-0006u5-JZ for linux-f2fs-devel@lists.sourceforge.net; Mon, 28 Oct 2024 11:21:25 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1730114472; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=KLtHY9tS67dDZxAwj9pQlA2Bn0F9rB4pbPk7zyiMrFE=; b=wpoM+gfqNmz7Dex6Ij59PM2QJfzqz2tTHMw67/VYooUlUOYKUcaiTcfDsL33HOgHb4NOK5 EqxsrtZBQphERvRf56Eh692br/n+TNqrncum5/EY0ZALKF1miOZSlayBvL12vAOn7hqqIt ZwFhqyTgpzEL2RL/RR+zD1EWMhXr89Y= From: Thorsten Blum To: Jaegeuk Kim , Chao Yu Date: Mon, 28 Oct 2024 12:20:58 +0100 Message-ID: <20241028112058.3346-2-thorsten.blum@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Headers-End: 1t5NoJ-0006u5-JZ Subject: [f2fs-dev] [RESEND PATCH] f2fs: Use struct_size() to improve f2fs_acl_clone() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Thorsten Blum , linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Use struct_size() to calculate the number of bytes to allocate for a cloned acl. Reviewed-by: Chao Yu Signed-off-by: Thorsten Blum --- fs/f2fs/acl.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c index 8bffdeccdbc3..1fbc0607363b 100644 --- a/fs/f2fs/acl.c +++ b/fs/f2fs/acl.c @@ -296,9 +296,8 @@ static struct posix_acl *f2fs_acl_clone(const struct posix_acl *acl, struct posix_acl *clone = NULL; if (acl) { - int size = sizeof(struct posix_acl) + acl->a_count * - sizeof(struct posix_acl_entry); - clone = kmemdup(acl, size, flags); + clone = kmemdup(acl, struct_size(acl, a_entries, acl->a_count), + flags); if (clone) refcount_set(&clone->a_refcount, 1); } -- 2.47.0 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [95.215.58.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA7621990AD for ; Mon, 28 Oct 2024 11:21:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730114476; cv=none; b=G0NqJ62hLzPVGKvUQMldwiKwp6ZrqPwSl96iVxqELzNqyL7ez4HLOcLqKF0HZ+X2JVrJQINT/Uiwfppbz2ohFEjvAmfYksJ2C/qOuK7HC/VHxMiEUBk/H4WNviibB+yAQetFkVhv85xngU23afq2C005iWc8qbxuAYYLIzkp05o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730114476; c=relaxed/simple; bh=THKWmR2YFhTE4Gq8LFDOvjdB5gfvH8D1//XRmLSEhjo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=SFMdSoFn9Tg1w+ByhrCug0r7KW+K9Uyk8JCvEpyT2AdubYWngRQJ34l6sg+GeJd5qJkh4oRKVN0UMX1XX2Zhp21mihCSivF1hJA+F8uuqFcoMoWxpo8o25Yi6xXGAx9j/puJApiguW/Qi8Tg2HUMcIf/tHtCUbNml9/FM35MzRk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=wpoM+gfq; arc=none smtp.client-ip=95.215.58.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="wpoM+gfq" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1730114472; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=KLtHY9tS67dDZxAwj9pQlA2Bn0F9rB4pbPk7zyiMrFE=; b=wpoM+gfqNmz7Dex6Ij59PM2QJfzqz2tTHMw67/VYooUlUOYKUcaiTcfDsL33HOgHb4NOK5 EqxsrtZBQphERvRf56Eh692br/n+TNqrncum5/EY0ZALKF1miOZSlayBvL12vAOn7hqqIt ZwFhqyTgpzEL2RL/RR+zD1EWMhXr89Y= From: Thorsten Blum To: Jaegeuk Kim , Chao Yu Cc: Thorsten Blum , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [RESEND PATCH] f2fs: Use struct_size() to improve f2fs_acl_clone() Date: Mon, 28 Oct 2024 12:20:58 +0100 Message-ID: <20241028112058.3346-2-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Use struct_size() to calculate the number of bytes to allocate for a cloned acl. Reviewed-by: Chao Yu Signed-off-by: Thorsten Blum --- fs/f2fs/acl.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c index 8bffdeccdbc3..1fbc0607363b 100644 --- a/fs/f2fs/acl.c +++ b/fs/f2fs/acl.c @@ -296,9 +296,8 @@ static struct posix_acl *f2fs_acl_clone(const struct posix_acl *acl, struct posix_acl *clone = NULL; if (acl) { - int size = sizeof(struct posix_acl) + acl->a_count * - sizeof(struct posix_acl_entry); - clone = kmemdup(acl, size, flags); + clone = kmemdup(acl, struct_size(acl, a_entries, acl->a_count), + flags); if (clone) refcount_set(&clone->a_refcount, 1); } -- 2.47.0