From: Alejandro Vallejo <alejandro.vallejo@cloud.com>
To: xen-devel@lists.xenproject.org
Cc: "Alejandro Vallejo" <alejandro.vallejo@cloud.com>,
"Jan Beulich" <jbeulich@suse.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: [PATCH 02/14] x86/xstate: Create map/unmap primitives for xsave areas
Date: Mon, 28 Oct 2024 15:49:20 +0000 [thread overview]
Message-ID: <20241028154932.6797-3-alejandro.vallejo@cloud.com> (raw)
In-Reply-To: <20241028154932.6797-1-alejandro.vallejo@cloud.com>
Add infrastructure to simplify ASI handling. With ASI in the picture
we'll have several different means of accessing the XSAVE area of a
given vCPU, depending on whether a domain is covered by ASI or not and
whether the vCPU is question is scheduled on the current pCPU or not.
Having these complexities exposed at the call sites becomes unwieldy
very fast. These wrappers are intended to be used in a similar way to
map_domain_page() and unmap_domain_page(); The map operation will
dispatch the appropriate pointer for each case in a future patch, while
unmap will remain a no-op where no unmap is required (e.g: when there's
no ASI) and remove the transient maping if one was required.
Follow-up patches replace all uses of raw v->arch.xsave_area by this
mechanism in preparation to add the beforementioned dispatch logic to be
added at a later time.
Signed-off-by: Alejandro Vallejo <alejandro.vallejo@cloud.com>
---
xen/arch/x86/include/asm/xstate.h | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/xen/arch/x86/include/asm/xstate.h b/xen/arch/x86/include/asm/xstate.h
index 07017cc4edfd..36260459667c 100644
--- a/xen/arch/x86/include/asm/xstate.h
+++ b/xen/arch/x86/include/asm/xstate.h
@@ -143,4 +143,24 @@ static inline bool xstate_all(const struct vcpu *v)
(v->arch.xcr0_accum & XSTATE_LAZY & ~XSTATE_FP_SSE);
}
+/*
+ * Fetch a pointer to the XSAVE area of a vCPU
+ *
+ * If ASI is enabled for the domain, this mapping is pCPU-local.
+ *
+ * @param v Owner of the XSAVE area
+ */
+#define vcpu_map_xsave_area(v) ((v)->arch.xsave_area)
+
+/*
+ * Drops the XSAVE area of a vCPU and nullifies its pointer on exit.
+ *
+ * If ASI is enabled and v is not the currently scheduled vCPU then the
+ * per-pCPU mapping is removed from the address space.
+ *
+ * @param v vCPU logically owning xsave_area
+ * @param xsave_area XSAVE blob of v
+ */
+#define vcpu_unmap_xsave_area(v, x) ({ (x) = NULL; })
+
#endif /* __ASM_XSTATE_H */
--
2.47.0
next prev parent reply other threads:[~2024-10-28 15:50 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 15:49 [PATCH 00/14] x86: Address Space Isolation FPU preparations Alejandro Vallejo
2024-10-28 15:49 ` [PATCH 01/14] x86/xstate: Update stale assertions in fpu_x{rstor,save}() Alejandro Vallejo
2024-10-28 17:16 ` Andrew Cooper
2024-10-29 8:13 ` Jan Beulich
2024-10-29 10:56 ` Alejandro Vallejo
2024-10-28 15:49 ` Alejandro Vallejo [this message]
2024-10-28 17:20 ` [PATCH 02/14] x86/xstate: Create map/unmap primitives for xsave areas Andrew Cooper
2024-10-29 11:57 ` Alejandro Vallejo
2024-10-29 13:24 ` Frediano Ziglio
2024-10-29 14:23 ` Alejandro Vallejo
2024-10-29 13:28 ` Jan Beulich
2024-10-29 14:12 ` Alejandro Vallejo
2024-10-29 8:19 ` Jan Beulich
2024-10-29 10:55 ` Alejandro Vallejo
2024-10-28 15:49 ` [PATCH 03/14] x86/hvm: Map/unmap xsave area in hvm_save_cpu_ctxt() Alejandro Vallejo
2024-10-28 15:49 ` [PATCH 04/14] x86/fpu: Map/umap xsave area in vcpu_{reset,setup}_fpu() Alejandro Vallejo
2024-10-28 15:49 ` [PATCH 05/14] x86/xstate: Map/unmap xsave area in xstate_set_init() and handle_setbv() Alejandro Vallejo
2024-10-29 8:26 ` Jan Beulich
2024-10-29 13:00 ` Alejandro Vallejo
2024-10-29 13:31 ` Jan Beulich
2024-10-29 14:14 ` Alejandro Vallejo
2024-10-28 15:49 ` [PATCH 06/14] x86/hvm: Map/unmap xsave area in hvmemul_{get,put}_fpu() Alejandro Vallejo
2024-10-29 8:30 ` Jan Beulich
2024-10-28 15:49 ` [PATCH 07/14] x86/domctl: Map/unmap xsave area in arch_get_info_guest() Alejandro Vallejo
2024-10-28 15:49 ` [PATCH 08/14] x86/xstate: Map/unmap xsave area in {compress,expand}_xsave_states() Alejandro Vallejo
2024-10-28 15:49 ` [PATCH 09/14] x86/emulator: Refactor FXSAVE_AREA to use wrappers Alejandro Vallejo
2024-10-28 15:49 ` [PATCH 10/14] x86/mpx: Map/unmap xsave area in in read_bndcfgu() Alejandro Vallejo
2024-10-29 8:27 ` Jan Beulich
2024-10-28 15:49 ` [PATCH 11/14] x86/mpx: Adjust read_bndcfgu() to clean after itself Alejandro Vallejo
2024-10-29 8:32 ` Jan Beulich
2024-10-28 15:49 ` [PATCH 12/14] x86/fpu: Pass explicit xsave areas to fpu_(f)xsave() Alejandro Vallejo
2024-10-29 8:37 ` Jan Beulich
2024-10-29 10:59 ` Alejandro Vallejo
2024-10-28 15:49 ` [PATCH 13/14] x86/fpu: Pass explicit xsave areas to fpu_(f)xrstor() Alejandro Vallejo
2024-10-29 8:40 ` Jan Beulich
2024-10-28 15:49 ` [PATCH 14/14] x86/xstate: Make xstate_all() and vcpu_xsave_mask() take explicit xstate Alejandro Vallejo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028154932.6797-3-alejandro.vallejo@cloud.com \
--to=alejandro.vallejo@cloud.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.