From: Christoph Hellwig <hch@lst.de>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: Christoph Hellwig <hch@lst.de>,
Yang Erkun <yangerkun@huaweicloud.com>,
axboe@kernel.dk, ulf.hansson@linaro.org, houtao1@huawei.com,
penguin-kernel@i-love.sakura.ne.jp, linux-block@vger.kernel.org,
yangerkun@huawei.com, "yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH] brd: defer automatic disk creation until module initialization succeeds
Date: Mon, 28 Oct 2024 17:13:46 +0100 [thread overview]
Message-ID: <20241028161346.GA29122@lst.de> (raw)
In-Reply-To: <c2ec4267-6cd6-43ec-2857-287d4610441c@huaweicloud.com>
On Mon, Oct 28, 2024 at 07:29:54PM +0800, Yu Kuai wrote:
> I don't quite understand this, if the gendisk already exists,
> the probe callback won't be called from the open path, because
> ilookup() from blkdev_get_no_open() will found the bdev inode.
> Hence there will only be a small race windown for concurrent
> create on open callers to return -EEXIST here.
True. I'd still avoid the noice printk for that corner case, though.
next prev parent reply other threads:[~2024-10-28 16:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 9:07 [PATCH] brd: defer automatic disk creation until module initialization succeeds Yang Erkun
2024-10-28 9:44 ` Christoph Hellwig
2024-10-28 11:14 ` yangerkun
2024-10-28 11:29 ` Yu Kuai
2024-10-28 16:13 ` Christoph Hellwig [this message]
2024-10-29 3:12 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028161346.GA29122@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=houtao1@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=ulf.hansson@linaro.org \
--cc=yangerkun@huawei.com \
--cc=yangerkun@huaweicloud.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.