From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: Mohsin Bashir <mohsin.bashr@gmail.com>, <netdev@vger.kernel.org>,
<alexanderduyck@fb.com>, <andrew@lunn.ch>,
<andrew+netdev@lunn.ch>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>,
<kernel-team@meta.com>, <sanmanpradhan@meta.com>,
<sdf@fomichev.me>, <vadim.fedorenko@linux.dev>
Subject: Re: [PATCH net-next v2] eth: fbnic: Add support to write TCE TCAM entries
Date: Mon, 28 Oct 2024 16:35:54 -0700 [thread overview]
Message-ID: <20241028163554.7dddff8b@kernel.org> (raw)
In-Reply-To: <5a640b00-2ab2-472f-b713-1bb97ceac6ca@intel.com>
On Fri, 25 Oct 2024 17:19:03 +0200 Alexander Lobakin wrote:
> > +static void fbnic_clear_tce_tcam_entry(struct fbnic_dev *fbd, unsigned int idx)
> > +{
> > + int i;
> > +
> > + /* Invalidate entry and clear addr state info */
> > + for (i = 0; i <= FBNIC_TCE_TCAM_WORD_LEN; i++)
>
> Please declare loop iterators right in loop declarations, we're GNU11
> for a couple years already.
>
> for (u32 i = 0; ...
Why?
Please avoid giving people subjective stylistic feedback, especially
when none of the maintainers have given such feedback in the past.
> (+ don't use signed when it can't be < 0)
Again, why. int is the most basic type in C, why is using a fixed side
kernel type necessary here?
next prev parent reply other threads:[~2024-10-28 23:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 22:31 [PATCH net-next v2] eth: fbnic: Add support to write TCE TCAM entries Mohsin Bashir
2024-10-25 12:52 ` Simon Horman
2024-10-25 15:19 ` Alexander Lobakin
2024-10-28 23:35 ` Jakub Kicinski [this message]
2024-10-29 15:30 ` Alexander Lobakin
2024-10-30 0:26 ` Jakub Kicinski
2024-10-30 18:34 ` Andrew Lunn
2024-10-31 1:19 ` Mohsin Bashir
[not found] ` <97383310-c846-493a-a023-4d8033c5680b@gmail.com>
2024-10-31 12:43 ` Andrew Lunn
2024-10-31 22:13 ` Mohsin Bashir
2024-11-01 12:33 ` Andrew Lunn
2024-11-01 23:04 ` Alexander H Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028163554.7dddff8b@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-team@meta.com \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sanmanpradhan@meta.com \
--cc=sdf@fomichev.me \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.