Re: [PATCH v2 3/3] drm/panthor: Report innocent group kill

[Boris Brezillon <boris.brezillon@collabora.com>]

On Mon, 28 Oct 2024 15:31:19 +0000
Steven Price <steven.price@arm.com> wrote:

> On 28/10/2024 11:48, Boris Brezillon wrote:
> > Groups can be killed during a reset even though they did nothing wrong.
> > That usually happens when the FW is put in a bad state by other groups,
> > resulting in group suspension failures when the reset happens.
> > 
> > If we end up in that situation, flag the group innocent and report
> > innocence through a new DRM_PANTHOR_GROUP_STATE flag.  
> 
> Sadly I don't see any code to return that new flag... Shouldn't there be
> a change to panthor_get_get_state()?

My bad, I had those changes in a debug commit and somehow overlooked the
following two lines when preparing the final version:

@@ -3570,6 +3586,8 @@ int panthor_group_get_state(struct panthor_file
*pfile, get_state->state |= DRM_PANTHOR_GROUP_STATE_FATAL_FAULT;
                get_state->fatal_queues = group->fatal_queues;
        }
+       if (group->innocent)
+               get_state->state |= DRM_PANTHOR_GROUP_STATE_INNOCENT;
        mutex_unlock(&sched->lock);
 
        group_put(group);

Will send a v3 shortly.