From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Justin Weiss" <justin@justinweiss.com>,
"Alex Lanzano" <lanzano.alex@gmail.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Derek J . Clark" <derekjohn.clark@gmail.com>,
"Philip Müller" <philm@manjaro.org>
Subject: Re: [PATCH v4 1/4] iio: imu: bmi270: Add triggered buffer for Bosch BMI270 IMU
Date: Mon, 28 Oct 2024 20:08:22 +0000 [thread overview]
Message-ID: <20241028200822.0b981c9a@jic23-huawei> (raw)
In-Reply-To: <Zx9Ycjnlef1RJfGf@smile.fi.intel.com>
On Mon, 28 Oct 2024 11:25:06 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Sun, Oct 27, 2024 at 10:20:22AM -0700, Justin Weiss wrote:
> > Set up a triggered buffer for the accel and angl_vel values.
>
> ...
>
> > .channel2 = IIO_MOD_##_axis, \
> > .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), \
> > + .scan_index = BMI270_SCAN_ACCEL_##_axis, \
> > + .scan_type = { \
> > + .sign = 's', \
> > + .realbits = 16, \
> > + .storagebits = 16, \
> > + .endianness = IIO_LE \
>
> Leave trailing comma here.
>
> > + }, \
>
> ...
>
> > .channel2 = IIO_MOD_##_axis, \
> > .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), \
> > + .scan_index = BMI270_SCAN_GYRO_##_axis, \
> > + .scan_type = { \
> > + .sign = 's', \
> > + .realbits = 16, \
> > + .storagebits = 16, \
> > + .endianness = IIO_LE \
>
> Ditto.
>
> > + }, \
>
Agreed. Tweaked whilst applying
Jonathan
next prev parent reply other threads:[~2024-10-28 20:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-27 17:20 [PATCH v4 0/4] Add i2c driver for Bosch BMI260 IMU Justin Weiss
2024-10-27 17:20 ` [PATCH v4 1/4] iio: imu: bmi270: Add triggered buffer for Bosch BMI270 IMU Justin Weiss
2024-10-28 9:25 ` Andy Shevchenko
2024-10-28 20:08 ` Jonathan Cameron [this message]
2024-10-27 17:20 ` [PATCH v4 2/4] iio: imu: bmi270: Add scale and sampling frequency to " Justin Weiss
2024-10-28 9:32 ` Andy Shevchenko
2024-10-28 20:14 ` Jonathan Cameron
2024-10-27 17:20 ` [PATCH v4 3/4] dt-bindings: iio: imu: bmi270: Add Bosch BMI260 Justin Weiss
2024-10-27 20:26 ` Krzysztof Kozlowski
2024-10-27 17:20 ` [PATCH v4 4/4] iio: imu: bmi270: Add support for BMI260 Justin Weiss
2024-10-28 9:23 ` Andy Shevchenko
2024-10-28 20:18 ` [PATCH v4 0/4] Add i2c driver for Bosch BMI260 IMU Jonathan Cameron
2024-10-31 0:22 ` Justin Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028200822.0b981c9a@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=derekjohn.clark@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=justin@justinweiss.com \
--cc=krzk+dt@kernel.org \
--cc=lanzano.alex@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philm@manjaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.