From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fiona Klute via buildroot <buildroot@buildroot.org>
Cc: Fiona Klute <fiona.klute@gmx.de>
Subject: Re: [Buildroot] [PATCH 1/1] docs/manual/adding-packages-directory: describe start script details
Date: Mon, 28 Oct 2024 21:57:01 +0100 [thread overview]
Message-ID: <20241028215701.61fc6893@windsurf> (raw)
In-Reply-To: <20241028172943.2147885-1-fiona.klute@gmx.de>
On Mon, 28 Oct 2024 18:29:43 +0100
Fiona Klute via buildroot <buildroot@buildroot.org> wrote:
> From: "Fiona Klute (WIWA)" <fiona.klute@gmx.de>
>
> This codifies style elements discussed on the mailing list, most
> importantly PID file handling, and adds detailed considerations for
> writing start scripts.
Thanks for this!
> +==== Stopping the service
> +
> +The stop function should check that the daemon process is actually
> +gone before returning, otherwise restart might fail because the new
> +instance is started before the old one has actually stopped. How to do
> +that depends on how the PID file for the service is handled (see
> +above). It is recommended to always append +--exec "/sbin/$DAEMON"+ to
> +all +start-stop-daemon+ commands to ensure signals are set to a PID
^^^ sent
Applied with this minor nit fixed! Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-10-28 20:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 17:29 [Buildroot] [PATCH 1/1] docs/manual/adding-packages-directory: describe start script details Fiona Klute via buildroot
2024-10-28 20:57 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028215701.61fc6893@windsurf \
--to=buildroot@buildroot.org \
--cc=fiona.klute@gmx.de \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.