Re: [Buildroot] [PATCH v3 1/5] board/qemu/riscv{32, 64}-virt: do not use the default bus implicitly

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Sat, 26 Oct 2024 13:00:55 +0200
Romain Naour via buildroot <buildroot@buildroot.org> wrote:

> From: Waldemar Brodkorb <wbx@openadk.org>
> 
> Qemu 9.1 recently fixed the RISC-V virt target by adding the missing
> default type for block devices [1].
> 
> But the qemu command line we use for RISC-V virt is slightly incorrect:
> 
>   -drive file=rootfs.ext2,format=raw,id=hd0 -device virtio-blk-device,drive=hd0
> 
> With Qemu 9.1, this command line now rejected since it conflict with
> the new default bus:
> 
>   qemu-system-riscv64: -drive file=rootfs.ext2,format=raw,id=hd0: Drive 'hd0' is already in use because it has been automatically connected to another device (did you need 'if=none' in the drive options?)
> 
> Since we are currently still using Qemu 9.0, apply the suggested change by
> adding 'if=none'.
> 
> Note: '-drive file=rootfs.ext2,format=raw,id=hd0' can be removed
> in a followup patch after the qemu version bump 9.1 is merged.
> 
> [1] https://gitlab.com/qemu-project/qemu/-/commit/4406ba2b5efce6af64905f827ca244f699db8170
> 
> [Romain: rework the commit log]
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> Signed-off-by: Romain Naour <romain.naour@smile.fr>
> ---
>  board/qemu/riscv32-virt/readme.txt     | 4 ++--
>  board/qemu/riscv64-virt-efi/readme.txt | 2 +-
>  board/qemu/riscv64-virt/readme.txt     | 4 ++--
>  3 files changed, 5 insertions(+), 5 deletions(-)

Thanks, series applied!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot