Re: [Buildroot] [PATCH] package:uclibc-ng:enable gnu hash for non mips platforms

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Hans,

Thanks for your patch!

On Sun,  8 Sep 2024 10:36:36 +0200
Hans Ulli Kroll <linux@ulli-kroll.de> wrote:

> In toolchain-wrapper.mk we use both sysv and gnu hash style for all
> platforms, except MIPS which uses sysv only.

The logic in toolchain-wrapper.mk regarding --hash-style is about
building the toolchain-wrapper executable for the host. So I really
don't see how this can be related to the uClibc library built for the
target.

> However uClibc-ng has some extra knob to enable gnu hash via Kconfig,
> which is set by default off.
> 
> This leads to wrong symbol resolving on armv5 and output of devices,
> here on Pogoplug 4 detected with lcpci 3.10.

In principle, I have nothing against your patch, but I must say I don't
really understand why it solves your problem, and what is the
impact/consequences.

Hans, do you have more details on the problems you are seeing?

Waldemar, any input?

As far as I can see from a quick look, we default to --hash-style=both,
as far as I can see in the Busybox binary:

  [ 3] .hash             HASH            00000190 000190 000a10 04   A  5   0  4
  [ 4] .gnu.hash         GNU_HASH        00000ba0 000ba0 000018 04   A  5   0  4

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot