From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Brian Geffon <bgeffon@google.com>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Minchan Kim <minchan@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 2/2] zram: clear IDLE flag in mark_idle()
Date: Tue, 29 Oct 2024 09:09:54 +0900 [thread overview]
Message-ID: <20241029000954.GU1279924@google.com> (raw)
In-Reply-To: <Zx_QblcMMLznXd4P@google.com>
On (24/10/28 13:57), Brian Geffon wrote:
> On Tue, Oct 29, 2024 at 12:36:15AM +0900, Sergey Senozhatsky wrote:
> > If entry does not fulfill current mark_idle() parameters, e.g.
> > cutoff time, then we should clear its ZRAM_IDLE from previous
> > mark_idle() invocations.
> >
> > Consider the following case:
> > - mark_idle() cutoff time 8h
> > - mark_idle() cutoff time 4h
> > - writeback() idle - will writeback entries with cutoff time 8h,
> > while it should only pick entries with cutoff time 4h
> >
> > The bug was reported by Shin Kawamura.
> Reported-by: Shin Kawamura <kawasin@google.com>
This is how it was in v1, but that triggered a warn
WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
#16:
Reported-by: Shin Kawamura <kawasin@google.com>
Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
so I switched to less "formal" reported-by tag in v2.
prev parent reply other threads:[~2024-10-29 0:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 15:36 [PATCHv2 0/2] zram: IDLE flag handling fixes Sergey Senozhatsky
2024-10-28 15:36 ` [PATCHv2 1/2] zram: clear IDLE flag after recompression Sergey Senozhatsky
2024-10-28 17:56 ` Brian Geffon
2024-10-28 15:36 ` [PATCHv2 2/2] zram: clear IDLE flag in mark_idle() Sergey Senozhatsky
2024-10-28 17:57 ` Brian Geffon
2024-10-29 0:09 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241029000954.GU1279924@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=bgeffon@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.