From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: mm-commits@vger.kernel.org, minchan@kernel.org,
kawasin@google.com, senozhatsky@chromium.org
Subject: Re: + zram-clear-idle-flag-after-recompression.patch added to mm-unstable branch
Date: Tue, 29 Oct 2024 17:07:48 +0900 [thread overview]
Message-ID: <20241029080748.GV1279924@google.com> (raw)
In-Reply-To: <20241028221018.5481AC4CEC3@smtp.kernel.org>
On (24/10/28 15:10), Andrew Morton wrote:
> Patch series "zram: IDLE flag handling fixes".
>
> zram can wrongly preserve ZRAM_IDLE flag on its entries which can result
> in premature post-processing (writeback and recompression) of such
> entries.
>
>
> This patch (of 2):
>
> Recompression should clear ZRAM_IDLE flag on the entires it has accessed,
> because otherwise some entries, specifically those for which recompression
> has failed, become immediate candidate entries for another post-processing
> (e.g. writeback).
>
> Consider the following case:
> - recompression marks entries IDLE every 4 hours and attempts
> to recompress them
> - some entries are incompressible, so we keep them intact and
> hence preserve IDLE flag
> - writeback marks entries IDLE every 8 hours and writebacks
> IDLE entries, however we have IDLE entries left from
> recompression, so writeback prematurely writebacks those
> entries.
>
> Link: https://lkml.kernel.org/r/20241028073529.1383980-1-senozhatsky@chromium.org
> Link: https://lkml.kernel.org/r/20241028073529.1383980-2-senozhatsky@chromium.org
> Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
> Reported-by: Shin Kawamura <kawasin@google.com>
> Cc: Minchan Kim <minchan@kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Andrew, can I please ask you to replace these patches with v2 series?
v2 comes with styles and typos fixed.
https://lore.kernel.org/linux-kernel/20241028153629.1479791-1-senozhatsky@chromium.org
next prev parent reply other threads:[~2024-10-29 8:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 22:10 + zram-clear-idle-flag-after-recompression.patch added to mm-unstable branch Andrew Morton
2024-10-29 8:07 ` Sergey Senozhatsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-10-30 1:04 Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241029080748.GV1279924@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=kawasin@google.com \
--cc=minchan@kernel.org \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.