From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Frager, Neal" <neal.frager@amd.com>
Cc: "Simek, Michal" <michal.simek@amd.com>,
"luca.ceresoli@bootlin.com" <luca.ceresoli@bootlin.com>,
"brandon.maier@collins.com" <brandon.maier@collins.com>,
"buildroot@buildroot.org" <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH v1 1/1] package/bootgen: clean up variable names
Date: Tue, 29 Oct 2024 10:38:46 +0100 [thread overview]
Message-ID: <20241029103846.631ecfd5@windsurf> (raw)
In-Reply-To: <CH2PR12MB5004C6ED05628E45F099A388F04B2@CH2PR12MB5004.namprd12.prod.outlook.com>
On Tue, 29 Oct 2024 09:08:41 +0000
"Frager, Neal" <neal.frager@amd.com> wrote:
> If that is the case, then maybe these are wrong?
>
> https://github.com/buildroot/buildroot/blob/master/package/binutils-bare-metal/binutils-bare-metal.mk
> https://github.com/buildroot/buildroot/blob/master/package/gcc-bare-metal/gcc-bare-metal.mk
"Wrong" no, as they work, but we indeed normally define those variables
without a HOST_ prefix.
One thing that should be fixed is:
define GCC_BARE_METAL_CONFIGURE_SYMLINK
mkdir -p $(@D)/build
ln -sf ../configure $(@D)/build/configure
endef
HOST_GCC_BARE_METAL_PRE_CONFIGURE_HOOKS += GCC_BARE_METAL_CONFIGURE_SYMLINK
GCC_BARE_METAL_CONFIGURE_SYMLINK should be
HOST_GCC_BARE_METAL_CONFIGURE_SYMLINK.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-10-29 9:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 7:03 [Buildroot] [PATCH v1 1/1] package/bootgen: clean up variable names Neal Frager via buildroot
[not found] ` <4d5f14f8-6c70-426b-82fd-d023150e0332@gmx.de>
2024-10-29 7:57 ` Frager, Neal via buildroot
2024-10-29 9:01 ` Thomas Petazzoni via buildroot
2024-10-29 9:08 ` Frager, Neal via buildroot
2024-10-29 9:38 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241029103846.631ecfd5@windsurf \
--to=buildroot@buildroot.org \
--cc=brandon.maier@collins.com \
--cc=luca.ceresoli@bootlin.com \
--cc=michal.simek@amd.com \
--cc=neal.frager@amd.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.