From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Ronnie.Kunin@microchip.com, Fabi.Benschuh@fau.de,
Woojung.Huh@microchip.com, UNGLinuxDriver@microchip.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] Add LAN78XX OTP_ACCESS flag support
Date: Tue, 29 Oct 2024 10:43:13 -0700 [thread overview]
Message-ID: <20241029104313.6d15fd08@kernel.org> (raw)
In-Reply-To: <a0d6ef0c-5615-40fd-964d-11844389dc29@lunn.ch>
On Mon, 28 Oct 2024 20:19:04 +0100 Andrew Lunn wrote:
> > This is pretty much the same implementation that is already in place
> > for the Linux driver of the LAN743x PCIe device.
>
> That is good, it gives some degree of consistency. But i wounder if we
> should go further. I doubt these are the only two devices which
> support both EEPROM and OTP. It would be nicer to extend ethtool:
>
> ethtool -e|--eeprom-dump devname [raw on|off] [offset N] [length N] [otp] [eeprom]
After a cursory look at the conversation I wonder if it wouldn't
be easier to register devlink regions for eeprom and otp?
next prev parent reply other threads:[~2024-10-29 17:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 23:05 [PATCH] Add LAN78XX OTP_ACCESS flag support Fabian Benschuh
2024-10-28 12:38 ` Andrew Lunn
2024-10-28 15:02 ` Ronnie.Kunin
2024-10-28 19:19 ` Andrew Lunn
2024-10-28 23:31 ` Ronnie.Kunin
2024-10-29 17:43 ` Jakub Kicinski [this message]
2024-10-29 21:14 ` Andrew Lunn
2024-10-29 21:57 ` Jakub Kicinski
2024-10-30 6:18 ` Rakesh Babu Saladi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241029104313.6d15fd08@kernel.org \
--to=kuba@kernel.org \
--cc=Fabi.Benschuh@fau.de \
--cc=Ronnie.Kunin@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.