From: Jason Gunthorpe <jgg@ziepe.ca>
To: Joerg Roedel <joro@8bytes.org>
Cc: iommu@lists.linux.dev, Will Deacon <will@kernel.org>,
linux-kernel@vger.kernel.org, Joerg Roedel <jroedel@suse.de>
Subject: Re: [PATCH] iommu: Restore iommu_flush_iotlb_all()
Date: Tue, 29 Oct 2024 08:42:01 -0300 [thread overview]
Message-ID: <20241029114201.GH20281@ziepe.ca> (raw)
In-Reply-To: <20241029112302.63639-1-joro@8bytes.org>
On Tue, Oct 29, 2024 at 12:23:02PM +0100, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@suse.de>
>
> This patch restores the iommu_flush_iotlb_all() function.
> Commit
>
> 69e5a17511f6 ("iommu: Remove useless flush from iommu_create_device_direct_mappings()")
>
> claims it removed the last call-site, except it did not. There is still
> at least one caller in
>
> drivers/gpu/drm/msm/msm_iommu.c
Yikes, that iss some scary stuff
> so keep the function around until all call-sites are updated.
>
> Cc: Jason Gunthorpe <jgg@ziepe.ca>
> Fixes: 69e5a17511f6 ("iommu: Remove useless flush from iommu_create_device_direct_mappings()")
> Signed-off-by: Joerg Roedel <jroedel@suse.de>
> ---
> include/linux/iommu.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Strange that 0-day didn't flag this in my trees. We really need to get
0-day running on the iommu list too :\
Jason
next prev parent reply other threads:[~2024-10-29 11:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 11:23 [PATCH] iommu: Restore iommu_flush_iotlb_all() Joerg Roedel
2024-10-29 11:26 ` Will Deacon
2024-10-29 11:42 ` Jason Gunthorpe [this message]
2024-10-29 12:03 ` Joerg Roedel
2024-10-29 12:07 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241029114201.GH20281@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.