From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Subject: [PATCH v3 resend 4/8] drm/xe: Defer irq init until after xe_display_init_noaccel
Date: Tue, 29 Oct 2024 16:00:01 +0100 [thread overview]
Message-ID: <20241029150005.68440-5-maarten.lankhorst@linux.intel.com> (raw)
In-Reply-To: <20241029150005.68440-1-maarten.lankhorst@linux.intel.com>
Technically, I believe this means that xe_display_init_noirq and
xe_display_init_noaccel can be merged together now.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
drivers/gpu/drm/xe/xe_device.c | 12 ++++--------
drivers/gpu/drm/xe/xe_tile.c | 7 +++++++
2 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index d145f1376069e..c8bce9858b511 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -41,7 +41,6 @@
#include "xe_hw_engine_group.h"
#include "xe_hwmon.h"
#include "xe_irq.h"
-#include "xe_memirq.h"
#include "xe_mmio.h"
#include "xe_module.h"
#include "xe_observation.h"
@@ -683,9 +682,6 @@ int xe_device_probe(struct xe_device *xe)
err = xe_ggtt_init_early(tile->mem.ggtt);
if (err)
return err;
- err = xe_memirq_init(&tile->memirq);
- if (err)
- return err;
}
for_each_gt(gt, xe, id) {
@@ -705,10 +701,6 @@ int xe_device_probe(struct xe_device *xe)
if (err)
return err;
- err = xe_irq_install(xe);
- if (err)
- goto err;
-
err = probe_has_flat_ccs(xe);
if (err)
goto err;
@@ -746,6 +738,10 @@ int xe_device_probe(struct xe_device *xe)
goto err;
}
+ err = xe_irq_install(xe);
+ if (err)
+ goto err;
+
for_each_gt(gt, xe, id) {
last_gt = id;
diff --git a/drivers/gpu/drm/xe/xe_tile.c b/drivers/gpu/drm/xe/xe_tile.c
index 2825553b568f7..d07c1fba793ca 100644
--- a/drivers/gpu/drm/xe/xe_tile.c
+++ b/drivers/gpu/drm/xe/xe_tile.c
@@ -10,6 +10,7 @@
#include "xe_device.h"
#include "xe_ggtt.h"
#include "xe_gt.h"
+#include "xe_memirq.h"
#include "xe_migrate.h"
#include "xe_pcode.h"
#include "xe_sa.h"
@@ -179,6 +180,12 @@ int xe_tile_init_noalloc(struct xe_tile *tile)
int xe_tile_init(struct xe_tile *tile)
{
+ int err;
+
+ err = xe_memirq_init(&tile->memirq);
+ if (err)
+ return err;
+
tile->mem.kernel_bb_pool = xe_sa_bo_manager_init(tile, SZ_1M, 16);
if (IS_ERR(tile->mem.kernel_bb_pool))
return PTR_ERR(tile->mem.kernel_bb_pool);
--
2.45.2
next prev parent reply other threads:[~2024-10-29 15:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 14:59 [PATCH v3 resend 0/8] (CI) drm/xe: Fix initial framebuffer handover Maarten Lankhorst
2024-10-29 14:59 ` [PATCH v3 resend 1/8] drm/xe: Remove double pageflip Maarten Lankhorst
2024-10-29 14:59 ` [PATCH v3 resend 2/8] drm/i915/display: Use async flip when available for initial plane config Maarten Lankhorst
2024-10-29 19:08 ` Ville Syrjälä
2024-10-29 15:00 ` [PATCH v3 resend 3/8] drm/xe: Move suballocator init to after display init Maarten Lankhorst
2024-10-29 15:00 ` Maarten Lankhorst [this message]
2024-10-29 15:00 ` [PATCH v3 resend 5/8] drm/xe/display: Use a single early init call for display Maarten Lankhorst
2024-10-30 8:45 ` [PATCH v3.1 resend] " Maarten Lankhorst
2024-10-29 15:00 ` [PATCH v3 resend 6/8] drm/xe/sriov: Move VF bootstrap and query_config to vf_guc_init Maarten Lankhorst
2024-10-29 15:00 ` [PATCH v3 resend 7/8] drm/xe: Simplify GuC early initialisation Maarten Lankhorst
2024-10-30 11:27 ` [PATCH v3.1 resend] " Maarten Lankhorst
2024-10-29 15:00 ` [PATCH v3 resend 8/8] drm/xe: Split init of xe_gt_init_hwconfig to xe_gt_init and *_early Maarten Lankhorst
2024-10-29 18:07 ` ✓ CI.Patch_applied: success for (CI) drm/xe: Fix initial framebuffer handover Patchwork
2024-10-29 18:07 ` ✗ CI.checkpatch: warning " Patchwork
2024-10-29 18:08 ` ✗ CI.KUnit: failure " Patchwork
2024-10-30 9:31 ` ✓ CI.Patch_applied: success for (CI) drm/xe: Fix initial framebuffer handover. (rev2) Patchwork
2024-10-30 9:31 ` ✗ CI.checkpatch: warning " Patchwork
2024-10-30 9:32 ` ✗ CI.KUnit: failure " Patchwork
2024-10-30 11:33 ` ✓ CI.Patch_applied: success for (CI) drm/xe: Fix initial framebuffer handover. (rev3) Patchwork
2024-10-30 11:33 ` ✗ CI.checkpatch: warning " Patchwork
2024-10-30 11:34 ` ✓ CI.KUnit: success " Patchwork
2024-10-30 11:46 ` ✓ CI.Build: " Patchwork
2024-10-30 11:48 ` ✓ CI.Hooks: " Patchwork
2024-10-30 11:50 ` ✗ CI.checksparse: warning " Patchwork
2024-10-30 12:16 ` ✗ CI.BAT: failure " Patchwork
2024-10-30 13:41 ` ✗ CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241029150005.68440-5-maarten.lankhorst@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.