From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Francis Laniel <francis.laniel@amarulasolutions.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Raymond Mao <raymond.mao@linaro.org>
Subject: Re: [PATCH 03/21] bloblist: test: doc: Move into the common suite
Date: Tue, 29 Oct 2024 10:36:42 -0600 [thread overview]
Message-ID: <20241029163642.GA4959@bill-the-cat> (raw)
In-Reply-To: <CAFLszTgHHgBPByBdBxGWPpJ0tTkoTfZ=aN3MY80mFBR+CujvLw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1224 bytes --]
On Tue, Oct 29, 2024 at 04:45:40PM +0100, Simon Glass wrote:
> Hi Tom,
>
> On Mon, 28 Oct 2024 at 20:33, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Mon, Oct 28, 2024 at 01:41:08PM +0100, Simon Glass wrote:
> >
> > > There is no particular need for bloblist to have its own test suite.
> > > Move it into the common suite instead.
> > >
> > > Add the missing help for 'common' and update the docs.
> > >
> > > Signed-off-by: Simon Glass <sjg@chromium.org>
> >
> > This feels both like churn and weird. I would think "common" tests are
> > for things that are kinda legacy and too catch-all to have their own
> > subgroup.
>
> It's just chosen so that the test for common/ is in test/common - i.e.
> it makes it easier for people to find it.
Then I really don't understand renaming bloblist from something
descriptive to common which is not.
> BTW this series removes all tests from test/*.c and moves them into
> appropriate subdirs. Some of the tests are quite old so have just sat
> there all these years.
This is good, yes. But perhaps needs a bit more thought then about how
strong a mapping between filename/directory structure and test suite
name there needs to be.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2024-10-29 16:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 12:41 [PATCH 00/21] test: Tidy up the test/ directory Simon Glass
2024-10-28 12:41 ` [PATCH 01/21] bloblist: test: Move test into common Simon Glass
2024-11-01 21:46 ` Tom Rini
2024-11-02 16:32 ` Simon Glass
2024-10-28 12:41 ` [PATCH 02/21] bloblist: test: Drop global_data declarations Simon Glass
2024-10-28 12:41 ` [PATCH 03/21] bloblist: test: doc: Move into the common suite Simon Glass
2024-10-28 19:33 ` Tom Rini
2024-10-29 15:45 ` Simon Glass
2024-10-29 16:36 ` Tom Rini [this message]
2024-10-31 18:00 ` Simon Glass
2024-10-31 18:10 ` Tom Rini
2024-11-01 15:32 ` Simon Glass
2024-11-01 16:47 ` Tom Rini
2024-10-28 12:41 ` [PATCH 04/21] test: Drop test-trace.sh and common.sh Simon Glass
2024-10-28 12:41 ` [PATCH 05/21] compression: test: Move test into lib Simon Glass
2024-10-28 12:41 ` [PATCH 06/21] compression: test: Move into the lib suite Simon Glass
2024-10-28 12:41 ` [PATCH 07/21] command_ut: test: Move test into lib Simon Glass
2024-10-28 12:41 ` [PATCH 08/21] command: test: Move into the cmd suite Simon Glass
2024-10-28 12:41 ` [PATCH 09/21] test: Update command test to use unit-test functions Simon Glass
2024-10-28 12:41 ` [PATCH 10/21] bootm: test: Move test into boot Simon Glass
2024-10-28 12:41 ` [PATCH 11/21] test: Move print_ut test into common Simon Glass
2024-10-28 12:41 ` [PATCH 12/21] test: Move print_ut into the common suite Simon Glass
2024-10-28 12:41 ` [PATCH 13/21] test: Move str_ut test into lib Simon Glass
2024-10-28 12:41 ` [PATCH 14/21] str: test: Move into the lib suite Simon Glass
2024-10-28 12:41 ` [PATCH 15/21] test: Move unicode_ut test into lib Simon Glass
2024-10-28 12:41 ` [PATCH 16/21] test: Move unicode tests into the lib suite Simon Glass
2024-10-28 12:41 ` [PATCH 17/21] test: Move time_ut test into lib Simon Glass
2024-10-28 12:41 ` [PATCH 18/21] test: Move time tests into the lib suite Simon Glass
2024-10-28 12:41 ` [PATCH 19/21] test: Update time tests to use unit-test asserts Simon Glass
2024-10-28 12:41 ` [PATCH 20/21] test: Correct display of failing test Simon Glass
2024-10-28 12:41 ` [PATCH 21/21] test: Quote test names Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241029163642.GA4959@bill-the-cat \
--to=trini@konsulko.com \
--cc=francis.laniel@amarulasolutions.com \
--cc=ilias.apalodimas@linaro.org \
--cc=raymond.mao@linaro.org \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.