From: Jakub Kicinski <kuba@kernel.org>
To: Li Zhijian <lizhijian@fujitsu.com>
Cc: linux-kselftest@vger.kernel.org, shuah@kernel.org,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH for-next 7/7] selftests/net: Fix ./ns-XXXXXX not cleanup
Date: Tue, 29 Oct 2024 16:43:06 -0700 [thread overview]
Message-ID: <20241029164306.6122b372@kernel.org> (raw)
In-Reply-To: <20241025014010.6533-7-lizhijian@fujitsu.com>
On Fri, 25 Oct 2024 09:40:10 +0800 Li Zhijian wrote:
> ```
> readonly STATS="$(mktemp -p /tmp ns-XXXXXX)"
> readonly BASE=`basename $STATS`
> ```
> It could be a mistake to write to $BASE rather than $STATS, where $STATS
> is used to save the NSTAT_HISTORY and it will be cleaned up before exit.
Agreed, although since we've been creating the wrong file this whole
time and everything worked -- should we just just delete those two
lines completely?
Similarly to patch 6 - please repost as a standalone patch so that our
CI will test it. If you only CC a mailing list on subset of patches
they are likely to be ignored by automation..
--
pw-bot: cr
next prev parent reply other threads:[~2024-10-29 23:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 1:40 [PATCH for-next 1/7] selftests/alsa: Add a few missing gitignore files Li Zhijian
2024-10-25 1:40 ` [PATCH for-next 2/7] selftests/filesystems: Add missing gitignore file Li Zhijian
2024-10-25 1:40 ` [PATCH for-next 3/7] selftests/mm: Add a few missing gitignore files Li Zhijian
2024-10-25 19:10 ` John Hubbard
2024-10-25 1:40 ` [PATCH for-next 4/7] selftests/net: Add missing gitignore file Li Zhijian
2024-10-29 23:33 ` Jakub Kicinski
2024-10-25 1:40 ` [PATCH for-next 5/7] selftests/cpufreq: gitignore output files and clean them in make clean Li Zhijian
2024-10-25 1:40 ` [PATCH for-next 6/7] selftests/zram: gitignore output file Li Zhijian
2024-10-25 1:40 ` [PATCH for-next 7/7] selftests/net: Fix ./ns-XXXXXX not cleanup Li Zhijian
2024-10-29 23:43 ` Jakub Kicinski [this message]
2024-10-29 23:43 ` Jakub Kicinski
2024-10-30 0:54 ` Zhijian Li (Fujitsu)
2024-10-25 10:05 ` [PATCH for-next 1/7] selftests/alsa: Add a few missing gitignore files Mark Brown
2024-10-28 1:51 ` Zhijian Li (Fujitsu)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241029164306.6122b372@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.