From: Jakub Kicinski <kuba@kernel.org>
To: Stefan Wahren <wahrenst@gmx.net>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Simon Horman <horms@kernel.org>
Subject: Re: [PATCH net] net: vertexcom: mse102x: Fix possible double free of TX skb
Date: Tue, 29 Oct 2024 17:36:15 -0700 [thread overview]
Message-ID: <20241029173615.6492d1d5@kernel.org> (raw)
In-Reply-To: <ea4842c2-7c65-4d45-9964-1a1274d29ea4@gmx.net>
On Wed, 30 Oct 2024 00:06:46 +0100 Stefan Wahren wrote:
> > Exactly, I think it would work and it feels simpler.
> I didn't test it yet, i need access to evaluation board before. But this
> change will behave differently regarding stats of tx_bytes [1]. The
> first version will include the padding, while the second does not.
Good point! But I think we'd be moving in the right direction.
tx_bytes should count bytes sent to the network, not data+metadata
sent on an internal bus.
If you connect this board to a different controller directly the
rx_bytes of the other end should match the tx_bytes of the board
with mse102x. The byte accounting would benefit from further massaging
in a separate patch.
prev parent reply other threads:[~2024-10-30 0:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 15:52 [PATCH net] net: vertexcom: mse102x: Fix possible double free of TX skb Stefan Wahren
2024-10-24 9:49 ` Simon Horman
2024-10-29 19:10 ` Jakub Kicinski
2024-10-29 21:15 ` Stefan Wahren
2024-10-29 22:01 ` Jakub Kicinski
2024-10-29 23:06 ` Stefan Wahren
2024-10-30 0:36 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241029173615.6492d1d5@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.