From: Tom Rini <trini@konsulko.com>
To: Vasileios Amoiridis <vassilisamir@gmail.com>
Cc: michal.simek@amd.com, hs@denx.de, pro@denx.de, sjg@chromium.org,
vasileios.amoiridis@cern.ch, u-boot@lists.denx.de
Subject: Re: [PATCH v1 0/1] bootcount: zynqmp: Add bootcount API
Date: Tue, 29 Oct 2024 13:12:30 -0600 [thread overview]
Message-ID: <20241029191230.GG4959@bill-the-cat> (raw)
In-Reply-To: <20241029185814.7937-1-vassilisamir@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 683 bytes --]
On Tue, Oct 29, 2024 at 07:58:13PM +0100, Vasileios Amoiridis wrote:
> From: Vasileios Amoiridis <vasileios.amoiridis@cern.ch>
>
> Add support for the bootcount API by utilizing the internal Persistent
> Global General Registers of the PMU. These registers get reset whenever
> there is a Power-On-Reset so it makes them suitable for the API.
>
> Questions towards reviewers:
>
> 1) Is the licensing of the file ok?
Yes.
> 2) How am I supposed to add a maintainer for this file?
This should be caught already under the zynqmp regex in the top-level
MAINTAINERS file.
The code itself looks fine, but I'll leave it to Michal to further
review.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2024-10-29 19:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 18:58 [PATCH v1 0/1] bootcount: zynqmp: Add bootcount API Vasileios Amoiridis
2024-10-29 18:58 ` [PATCH v1 1/1] drivers: bootcount: Add ZynqMP specific bootcount support Vasileios Amoiridis
2024-10-30 5:26 ` Heiko Schocher
2024-10-30 14:11 ` Vasileios Amoiridis
2024-10-30 13:13 ` Michal Simek
2024-10-30 14:38 ` Vasileios Amoiridis
2024-10-30 15:49 ` Michal Simek
2024-10-30 16:04 ` Vasileios Amoiridis
2024-10-31 9:04 ` Michal Simek
2024-10-29 19:12 ` Tom Rini [this message]
2024-10-30 13:59 ` [PATCH v1 0/1] bootcount: zynqmp: Add bootcount API Vasileios Amoiridis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241029191230.GG4959@bill-the-cat \
--to=trini@konsulko.com \
--cc=hs@denx.de \
--cc=michal.simek@amd.com \
--cc=pro@denx.de \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=vasileios.amoiridis@cern.ch \
--cc=vassilisamir@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.