All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 8/9] drm/i915/scaler: Make scaler in_use a bool
Date: Tue, 29 Oct 2024 23:10:29 +0200	[thread overview]
Message-ID: <20241029211030.13255-9-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20241029211030.13255-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Make scaler in_use a boolean since that's how it's used.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_types.h | 2 +-
 drivers/gpu/drm/i915/display/skl_scaler.c          | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index 8269331f33b7..bc6095fc713c 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -697,8 +697,8 @@ struct intel_initial_plane_config {
 };
 
 struct intel_scaler {
-	int in_use;
 	u32 mode;
+	bool in_use;
 };
 
 struct intel_crtc_scaler_state {
diff --git a/drivers/gpu/drm/i915/display/skl_scaler.c b/drivers/gpu/drm/i915/display/skl_scaler.c
index e5f566e323a0..3cff48443100 100644
--- a/drivers/gpu/drm/i915/display/skl_scaler.c
+++ b/drivers/gpu/drm/i915/display/skl_scaler.c
@@ -150,7 +150,7 @@ skl_update_scaler(struct intel_crtc_state *crtc_state, bool force_detach,
 	if (force_detach || !need_scaler) {
 		if (*scaler_id >= 0) {
 			scaler_state->scaler_users &= ~(1 << scaler_user);
-			scaler_state->scalers[*scaler_id].in_use = 0;
+			scaler_state->scalers[*scaler_id].in_use = false;
 
 			drm_dbg_kms(display->drm,
 				    "scaler_user index %u.%u: "
@@ -309,7 +309,7 @@ static int intel_atomic_setup_scaler(struct intel_crtc_scaler_state *scaler_stat
 				continue;
 
 			*scaler_id = j;
-			scaler_state->scalers[*scaler_id].in_use = 1;
+			scaler_state->scalers[*scaler_id].in_use = true;
 			break;
 		}
 	}
@@ -350,9 +350,9 @@ static int intel_atomic_setup_scaler(struct intel_crtc_scaler_state *scaler_stat
 		 * scaler 0 operates in high quality (HQ) mode.
 		 * In this case use scaler 0 to take advantage of HQ mode
 		 */
-		scaler_state->scalers[*scaler_id].in_use = 0;
+		scaler_state->scalers[*scaler_id].in_use = false;
 		*scaler_id = 0;
-		scaler_state->scalers[0].in_use = 1;
+		scaler_state->scalers[0].in_use = true;
 		mode = SKL_PS_SCALER_MODE_HQ;
 	} else {
 		mode = SKL_PS_SCALER_MODE_DYN;
-- 
2.45.2


  parent reply	other threads:[~2024-10-29 21:12 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-29 21:10 [PATCH 0/9] drm/i915/scaler: Scaler code cleanups Ville Syrjala
2024-10-29 21:10 ` [PATCH 1/9] drm/i915/scaler: s/intel_crtc/crtc/ etc Ville Syrjala
2024-10-30 11:46   ` Jani Nikula
2024-10-29 21:10 ` [PATCH 2/9] drm/i915/scaler: Remove redudant junk from skl_scaler.h Ville Syrjala
2024-10-30 11:46   ` Jani Nikula
2024-10-29 21:10 ` [PATCH 3/9] drm/i915/scaler: Pass the whole atomic state into intel_atomic_setup_scalers() Ville Syrjala
2024-10-30 11:47   ` Jani Nikula
2024-10-29 21:10 ` [PATCH 4/9] drm/i915/scaler: Clean up intel_atomic_setup_scalers() a bit Ville Syrjala
2024-11-07 11:02   ` Luca Coelho
2024-10-29 21:10 ` [PATCH 5/9] drm/i915/scaler: Convert the scaler code to intel_display Ville Syrjala
2024-10-30 11:49   ` Jani Nikula
2024-10-29 21:10 ` [PATCH 6/9] drm/i915/scaler: Carve up intel_atomic_setup_scalers() Ville Syrjala
2024-11-07 11:03   ` Luca Coelho
2024-10-29 21:10 ` [PATCH 7/9] drm/i915/scaler: Move pfit scaler into pfit state Ville Syrjala
2024-11-07 11:04   ` Luca Coelho
2024-10-29 21:10 ` Ville Syrjala [this message]
2024-11-07 11:05   ` [PATCH 8/9] drm/i915/scaler: Make scaler in_use a bool Luca Coelho
2024-10-29 21:10 ` [PATCH 9/9] drm/i915/scaler: Extract intel_allocate_scaler() Ville Syrjala
2024-11-07 11:05   ` Luca Coelho
2024-10-30  0:42 ` ✗ Fi.CI.SPARSE: warning for drm/i915/scaler: Scaler code cleanups Patchwork
2024-10-30  1:05 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-10-31 16:03   ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241029211030.13255-9-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.