From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: TIAN Yuanhao <tianyuanhao3@163.com>
Cc: buildroot@buildroot.org, Bernd Kuhls <bernd.kuhls@t-online.de>
Subject: Re: [Buildroot] [PATCH 1/1] package/ntp: add a patch to fix crashes
Date: Tue, 29 Oct 2024 22:52:11 +0100 [thread overview]
Message-ID: <20241029225211.2e908cfe@windsurf> (raw)
In-Reply-To: <20240904114903.4020-1-tianyuanhao3@163.com>
On Wed, 4 Sep 2024 04:49:03 -0700
TIAN Yuanhao <tianyuanhao3@163.com> wrote:
> This patch fixes a regression [1] introduced in ntpd 4.2.8p18 [2].
>
> ntpd[200]: Listen normally on 3 lo [::1]:123
> ntpd[200]: bind(20) AF_INET6 [fe80::bf3d:254d:dee0:d345%3]:123 flags 0x811 failed: Cannot assign requested address
> ntpd[200]: unable to create socket on enp0s3 (4) for [fe80::bf3d:254d:dee0:d345%3]:123
> ntpd[192]: daemon control: got EOF
> ntpd[192]: daemon child died with signal 11
> systemd[1]: ntpd.service: Control process exited, code=exited, status=70/SOFTWARE
> systemd[1]: ntpd.service: Failed with result 'exit-code'.
> systemd[1]: Failed to start Network Time Service.
>
> If the IPv6 link-local interface was not ready for binding on the first
> attempt, ntpd would segfault in update_interfaces(). The segfault would
> only occur when ntpd was started as part of the boot sequence. Most
> - but not all - boots were affected. Evidently it could happen that the
> timing of ntpd's start up was delayed enough that the IPv6 link-local
> interface was ready for the bind() call when it was first issued by
> open_socket() via create_interface().
>
> [1]: https://bugs.ntp.org/show_bug.cgi?id=3928
> [2]: https://bugs.ntp.org/show_bug.cgi?id=3913
>
> Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
> Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> ...-Fix-crash-when-binding-IPv6-address.patch | 33 +++++++++++++++++++
> 1 file changed, 33 insertions(+)
> create mode 100644 package/ntp/0003-Fix-crash-when-binding-IPv6-address.patch
Applied to master after adding more details in the patch commit
message, especially an Upstream: tag. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-10-29 21:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 11:49 [Buildroot] [PATCH 1/1] package/ntp: add a patch to fix crashes TIAN Yuanhao
2024-10-29 21:52 ` Thomas Petazzoni via buildroot [this message]
2024-11-20 20:46 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241029225211.2e908cfe@windsurf \
--to=buildroot@buildroot.org \
--cc=bernd.kuhls@t-online.de \
--cc=thomas.petazzoni@bootlin.com \
--cc=tianyuanhao3@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.