From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Baruch Siach via buildroot <buildroot@buildroot.org>
Cc: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Subject: Re: [Buildroot] [PATCH] package/ebtables: remove KERNEL_64_USERSPACE_32 workaround
Date: Tue, 29 Oct 2024 23:21:18 +0100 [thread overview]
Message-ID: <20241029232118.7d67f24a@windsurf> (raw)
In-Reply-To: <f068d8afdff3043860dcd894bc5076c1b3817ea5.1727425450.git.baruch@tkos.co.il>
On Fri, 27 Sep 2024 11:24:10 +0300
Baruch Siach via buildroot <buildroot@buildroot.org> wrote:
> This workaround breaks build with gcc 14.
>
> Upstream developers acknowledged[1] the 32/64 compatibility issue more
> than 3 years ago, but no proper fix has been applied. Specifically, for
> aarch64 we don't even enable BR2_KERNEL_64_USERLAND_32, so this
> workaround is not effective there.
>
> The least we can do is make ebtables depend on
> !BR2_KERNEL_64_USERLAND_32.
>
> [1] https://lore.kernel.org/all/20210518181730.13436-1-patrickdepinguin@gmail.com/
>
> Fixes:
> http://autobuild.buildroot.net/results/680674c2b61209b505efa022a8fd9751ddc5fd47/
> http://autobuild.buildroot.net/results/60f8f5f087111ec3f300dc7979363de5a9f64f08/
>
> Cc: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> .checkpackageignore | 2 -
> ...estore-KERNEL_64_USERSPACE_32-checks.patch | 105 ------------------
> ...-option-enable-kernel-64-userland-32.patch | 51 ---------
> package/ebtables/Config.in | 2 +
> package/ebtables/ebtables.mk | 6 -
> 5 files changed, 2 insertions(+), 164 deletions(-)
> delete mode 100644 package/ebtables/0002-ebtables.h-restore-KERNEL_64_USERSPACE_32-checks.patch
> delete mode 100644 package/ebtables/0003-configure.ac-add-option-enable-kernel-64-userland-32.patch
Applied to master, after propagating the dependency to
BR2_PACKAGE_LIBVIRT_DAEMON, which selects ebtables.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-10-29 22:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-27 8:24 [Buildroot] [PATCH] package/ebtables: remove KERNEL_64_USERSPACE_32 workaround Baruch Siach via buildroot
2024-10-29 22:21 ` Thomas Petazzoni via buildroot [this message]
2024-11-20 20:52 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241029232118.7d67f24a@windsurf \
--to=buildroot@buildroot.org \
--cc=thomas.de_schampheleire@nokia.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.