From: Christoph Hellwig <hch@lst.de>
To: Anuj Gupta <anuj20.g@samsung.com>
Cc: axboe@kernel.dk, hch@lst.de, kbusch@kernel.org,
martin.petersen@oracle.com, asml.silence@gmail.com,
anuj1072538@gmail.com, brauner@kernel.org, jack@suse.cz,
viro@zeniv.linux.org.uk, io-uring@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
gost.dev@samsung.com, linux-scsi@vger.kernel.org,
vishak.g@samsung.com, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v5 09/10] scsi: add support for user-meta interface
Date: Wed, 30 Oct 2024 06:10:16 +0100 [thread overview]
Message-ID: <20241030051016.GD32598@lst.de> (raw)
In-Reply-To: <20241029162402.21400-10-anuj20.g@samsung.com>
On Tue, Oct 29, 2024 at 09:54:01PM +0530, Anuj Gupta wrote:
> Add support for sending user-meta buffer. Set tags to be checked
> using flags specified by user/block-layer.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
> - if (bio_integrity_flagged(bio, BIP_CTRL_NOCHECK) == false)
> + if (bio_integrity_flagged(bio, BIP_CHECK_GUARD))
> scmd->prot_flags |= SCSI_PROT_GUARD_CHECK;
> }
>
> if (dif != T10_PI_TYPE3_PROTECTION) { /* DIX/DIF Type 0, 1, 2 */
> scmd->prot_flags |= SCSI_PROT_REF_INCREMENT;
>
> - if (bio_integrity_flagged(bio, BIP_CTRL_NOCHECK) == false)
> + if (bio_integrity_flagged(bio, BIP_CHECK_REFTAG))
BIP_CTRL_NOCHECK is unused now, and should probably go away.
next prev parent reply other threads:[~2024-10-30 5:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20241029163153epcas5p4ab83a94429a227bfc262423aa8a8dd26@epcas5p4.samsung.com>
2024-10-29 16:23 ` [PATCH v5 00/10] Read/Write with meta/integrity Anuj Gupta
2024-10-29 16:23 ` [PATCH v5 01/10] block: define set of integrity flags to be inherited by cloned bip Anuj Gupta
2024-10-29 16:23 ` [PATCH v5 02/10] block: copy back bounce buffer to user-space correctly in case of split Anuj Gupta
2024-10-29 16:23 ` [PATCH v5 03/10] block: modify bio_integrity_map_user to accept iov_iter as argument Anuj Gupta
2024-10-29 21:31 ` Keith Busch
2024-10-29 16:23 ` [PATCH v5 04/10] fs, iov_iter: define meta io descriptor Anuj Gupta
2024-10-30 5:03 ` Christoph Hellwig
2024-10-30 11:17 ` Kanchan Joshi
2024-10-29 16:23 ` [PATCH v5 05/10] fs: introduce IOCB_HAS_METADATA for metadata Anuj Gupta
2024-10-29 16:23 ` [PATCH v5 06/10] io_uring/rw: add support to send metadata along with read/write Anuj Gupta
2024-10-29 23:24 ` Keith Busch
2024-10-30 5:05 ` Kanchan Joshi
2024-10-30 5:08 ` Christoph Hellwig
2024-11-07 17:30 ` Pavel Begunkov
2024-11-08 7:12 ` Christoph Hellwig
2024-10-29 16:23 ` [PATCH v5 07/10] block: introduce BIP_CHECK_GUARD/REFTAG/APPTAG bip_flags Anuj Gupta
2024-10-29 21:40 ` Keith Busch
2024-10-30 5:09 ` Christoph Hellwig
2024-10-29 16:24 ` [PATCH v5 08/10] nvme: add support for passing on the application tag Anuj Gupta
2024-10-29 21:40 ` Keith Busch
2024-10-29 16:24 ` [PATCH v5 09/10] scsi: add support for user-meta interface Anuj Gupta
2024-10-30 5:10 ` Christoph Hellwig [this message]
2024-10-29 16:24 ` [PATCH v5 10/10] block: add support to pass user meta buffer Anuj Gupta
2024-10-29 21:52 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241030051016.GD32598@lst.de \
--to=hch@lst.de \
--cc=anuj1072538@gmail.com \
--cc=anuj20.g@samsung.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=gost.dev@samsung.com \
--cc=io-uring@vger.kernel.org \
--cc=jack@suse.cz \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=viro@zeniv.linux.org.uk \
--cc=vishak.g@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.