From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B2E11D3578 for ; Wed, 30 Oct 2024 07:19:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730272743; cv=none; b=oGzN/zsaUkA+kDdGRhoWW+Vc1fTD2VtAS3R3Qim7FGjo5pOoosBRHQoK/GcJKmtExlSvq9pKy+xM8qcr/T2RTDMQtUEK8QdDf0DPlfaKpExrz59oaQWYGWTKaaPrXpLVJularxOZRmkIEAzIcJM0FB3seP0ovd/rNShtQ1kJL80= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730272743; c=relaxed/simple; bh=GRFuDEnjDgd4OvoRG285WDJtwuTF8sf2Dvf2JM1Qzcw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pq2s+X++PAKNlfjqUtsLZn2NHfqa5YmOhw/uWiOzSLpKHtb4yiFIVdUv3G0gmXTBqUr6mN1GCiNPmnJPWwOR1ijCvDrSbJgsLuqFVRU7ovV11HT8yNvFdnPwNMUbBc0YggWGgiGPqW/7XPvlfcoGa3HBU7lkR8bMEtlJ2vTEgj4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=uXHkZFXq; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uXHkZFXq" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-20ce5e3b116so45220575ad.1 for ; Wed, 30 Oct 2024 00:19:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730272741; x=1730877541; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=2HfyfhF6z0IsAsG7O1iQKmomQevqTeSun6SJPILAuAM=; b=uXHkZFXqX77GhcG9bKQ/636UdZw45BxhQKW7dNrCZGkH1e7lD8+BxJM/Yc97+nL+H/ zSy7Rwz+PdBsfnjvgGwcAJgu+iRkgGLLa6P74LlhwjzglS2zrttpJy6dW+IlkTAz0BQw tkfYHR+qmhPr7Qhdl1cYFES7WEIp/yLPaubLij4PyRhMF0EGZLi5DBe+TBaSZOP6xsdM XWhYvZuI0l27nLC4oNx3azm8SA78oOOZTXrrJaK+k4MD0qunSRTM5KiB5eWDU+WNwlAo 0V/GoxnRt2Pr/CNYT7DgFwexU+dKQa6ht5hGjoayrkruuBW46Cbt2Ik0NgX6dWJF8KXG Vukg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730272741; x=1730877541; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2HfyfhF6z0IsAsG7O1iQKmomQevqTeSun6SJPILAuAM=; b=wtFXR49PdQbgeh787tCXfOVJbaJ3bT48BQ6z3pA4YJnkS0N+W+WPMXHqsGtg9Aw/Z1 2NfAjL1zAFWQuM84LN+Ef994I2E1nQ7mG8lTJDsvbMUINcnrwb17P+0v8DhhWCqn0jzN +tH/bLBgNpHizoT28uc6jSKyqGJd1QfWZ5IoBp3OZHG35E2t5viFXfjq3E/AlPIK3utB k63YHr/R2SS1FuTIc6xLF9oPL2V9MtBDXZwa/ZiggobPOhoFYH1+u0+cUeITsWO7Rtor n0uYZl7j3W9sGLytzp92V5UMzjHWfBtx5Fmjc74PaDLPFesA7EsjqrDgELxdo9SJJNGY Z6PQ== X-Forwarded-Encrypted: i=1; AJvYcCU2ZU4t54TIX9zVZW33hIxu7gdfYBb0n7zXb0uzLO2QQUi0AfLfqhyQJqFx9oNwwkEdAk2x3AgQCIuFKIfn@vger.kernel.org X-Gm-Message-State: AOJu0YzCmZM+8QxhZh3yFUuNo/QHJjzBpQ3PqZhanXgVxBDy4z6mO5uq RuUT1Q5zSw4XiRHweVrCg31VDd8NjdLQnEnpQDL0hABDiJcpAnp0X+Ai6a7U7Q== X-Google-Smtp-Source: AGHT+IHTdvrxjuDcs8dqC3K9rXQG1LndTCbbKrjV+g4Yj/M49myE6Ugo2CkOqvAophLbqnU9pTQ4Xw== X-Received: by 2002:a17:903:2445:b0:20b:775f:506d with SMTP id d9443c01a7336-210c6c123f3mr211614765ad.34.1730272740962; Wed, 30 Oct 2024 00:19:00 -0700 (PDT) Received: from thinkpad ([36.255.17.104]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-210bbf441bdsm75242015ad.52.2024.10.30.00.18.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Oct 2024 00:19:00 -0700 (PDT) Date: Wed, 30 Oct 2024 12:48:51 +0530 From: Manivannan Sadhasivam To: Johan Hovold Cc: Qiang Yu , vkoul@kernel.org, kishon@kernel.org, robh@kernel.org, andersson@kernel.org, konradybcio@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, abel.vesa@linaro.org, quic_msarkar@quicinc.com, quic_devipriy@quicinc.com, dmitry.baryshkov@linaro.org, kw@linux.com, lpieralisi@kernel.org, neil.armstrong@linaro.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, johan+linaro@kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v7 6/7] PCI: qcom: Disable ASPM L0s and remove BDF2SID mapping config for X1E80100 SoC Message-ID: <20241030071851.sdm3fu6ecaddoiit@thinkpad> References: <20241017030412.265000-1-quic_qianyu@quicinc.com> <20241017030412.265000-7-quic_qianyu@quicinc.com> <91395c5e-22a0-4117-a4b5-4985284289ab@quicinc.com> <250bce05-a095-4eb3-a445-70bbf4366526@quicinc.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Oct 30, 2024 at 08:15:05AM +0100, Johan Hovold wrote: > On Wed, Oct 30, 2024 at 01:54:59PM +0800, Qiang Yu wrote: > > On 10/24/2024 2:42 PM, Qiang Yu wrote: > > > On 10/18/2024 10:06 PM, Johan Hovold wrote: > > > >> Also say something about how L0s is broken so that it is more clear what > > >> the effect of this patch is. On sc8280xp enabling L0s lead to > > >> correctable errors for example. > > > > Need more time to confirm the exact reason about disabling L0s. > > > Will update if get any progress > > > I confirmed with HW team and SW team. L0s is not supported on X1E80100, > > it is not fully verified. So we don't want to enable it. > > Thanks for checking. A word about what can happen if not disabling it > may still be in place (e.g. the link state transition stats in debugfs > on x1e80100 looked pretty erratic with L0s enabled IIRC). > > Also, are there any Qualcomm platforms that actually support L0s? > Perhaps we should just disable it everywhere? > Most of the mobile chipsets from Qcom support L0s. It is not supported only on the compute ones. So we cannot disable it everywhere. Again, it is not the hw issue but the PHY init sequence not tuned support L0s. - Mani -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44A71D7497D for ; Wed, 30 Oct 2024 07:19:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=l/78hRh5tiZzXPad/GP29OY3ZY0LUuSxqrsgmHwH8uo=; b=DzXG3jUquWLOrA 5mOVORN80B5zHpm+jULSN75fn+5yYGQrv7iMpJ4XsCPzHNG+09LXZHKV9NXHJMu0ke8I+h2rMhM1n yAH8/LSmWOn3vQRrntVTSdy0hQORZUvmIQpobHikZO3G/yyU6sEhnMpFps+X4m5Hho8QbgXLRE3g5 4MGvwZwoudHshah/gEimUokKVO91gUM8sdO7AdgOya00r+AD0N2BjH8Yzk9ReysrA3lPsqRRC9Ilb qOb4WAOooUfXgfQikvFvCF3+5QisvR3scYtPt6m1saY9mgBh3VzikOG9HWb5ytTe5o6j8kJdYzKUc xClYWdwhT39nIM/sTr7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t62yv-0000000H7Eq-2Beo; Wed, 30 Oct 2024 07:19:05 +0000 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t62ys-0000000H7DU-2R89 for linux-phy@lists.infradead.org; Wed, 30 Oct 2024 07:19:03 +0000 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-20ca7fc4484so43463735ad.3 for ; Wed, 30 Oct 2024 00:19:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730272741; x=1730877541; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=2HfyfhF6z0IsAsG7O1iQKmomQevqTeSun6SJPILAuAM=; b=L9HM5jZH/8xIBappJl1lYXNCSvrAcWysYOw3R/hCqqg5AwpPJ/i8EKpaikhf5JSWbi BN7kkd6ST8Ae+IOG1Uxmot4hM89stvy9tUM1KgVp0hf8byPPyTlXIHuGoIURkTAcCpsI 3Iyl3pfHGiT9hRY59mfIMY8AbSkOgLewk025jdX+jlfYsC3NCKaDpY84qq4QzgIcnWVf zX9T/faFrIuGFf7ZZ/DEh6LHmgxDtLDm6oQqlaG7aIMJ0w9eUElqtBP+NZ8e2j3To9od yz+sZEc+13jFml1vmH3G/yXUvfMHQvZlJJ1t9q2JktRzjBr13qYtKuj06OPmSEp65nSd P/ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730272741; x=1730877541; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2HfyfhF6z0IsAsG7O1iQKmomQevqTeSun6SJPILAuAM=; b=sk7TeS2lboTkloOaTUZWE9UgexpWoDcgCQffdYj9DndKrQ+QgfSi1G4miw/1KK/cC9 tocGVzWMVtFG8zojYwLsPTcagWPJoBzomq48pV3+S2LUjw2gBkq2MXuHHj2E1YX2IwMB jUHacApQJjTGPtdyy0qVTlhOAZohAFpZhoO732rVAHloP/M8miHYfsSwec/masX462QM ePY1+JyYKhHibinS3c2Uk8lXpK/2iYbfEi/6Va6Oog/6MuWTHWUS7tzNBsk0P7OYkOoD hDb4gLFL090XJGZ0hqL4NEjpsFqUfeCC398ktMixPioVC1RyE50exyI1wwUoP58yw5nz a/uw== X-Forwarded-Encrypted: i=1; AJvYcCUbtdjTODmttsGijllw/izfhmXuvEp5YFmolYoQDU2QDda+7Agxj/9rNBQycuad6hJNe9yGqXA985k=@lists.infradead.org X-Gm-Message-State: AOJu0Yw9/wF9Aowl+RB/Zo4/ZmQ7dyhdhdeAxAhSIJYz+91rpEtpWgm5 Iwi8oWNHtLhE/a8SWXvZcfFFtn9cSgxEsYdMIIOH11T4EoQiAzCSoElobnHApA== X-Google-Smtp-Source: AGHT+IHTdvrxjuDcs8dqC3K9rXQG1LndTCbbKrjV+g4Yj/M49myE6Ugo2CkOqvAophLbqnU9pTQ4Xw== X-Received: by 2002:a17:903:2445:b0:20b:775f:506d with SMTP id d9443c01a7336-210c6c123f3mr211614765ad.34.1730272740962; Wed, 30 Oct 2024 00:19:00 -0700 (PDT) Received: from thinkpad ([36.255.17.104]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-210bbf441bdsm75242015ad.52.2024.10.30.00.18.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Oct 2024 00:19:00 -0700 (PDT) Date: Wed, 30 Oct 2024 12:48:51 +0530 From: Manivannan Sadhasivam To: Johan Hovold Cc: Qiang Yu , vkoul@kernel.org, kishon@kernel.org, robh@kernel.org, andersson@kernel.org, konradybcio@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, abel.vesa@linaro.org, quic_msarkar@quicinc.com, quic_devipriy@quicinc.com, dmitry.baryshkov@linaro.org, kw@linux.com, lpieralisi@kernel.org, neil.armstrong@linaro.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, johan+linaro@kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v7 6/7] PCI: qcom: Disable ASPM L0s and remove BDF2SID mapping config for X1E80100 SoC Message-ID: <20241030071851.sdm3fu6ecaddoiit@thinkpad> References: <20241017030412.265000-1-quic_qianyu@quicinc.com> <20241017030412.265000-7-quic_qianyu@quicinc.com> <91395c5e-22a0-4117-a4b5-4985284289ab@quicinc.com> <250bce05-a095-4eb3-a445-70bbf4366526@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241030_001902_656291_2156B459 X-CRM114-Status: GOOD ( 19.50 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org T24gV2VkLCBPY3QgMzAsIDIwMjQgYXQgMDg6MTU6MDVBTSArMDEwMCwgSm9oYW4gSG92b2xkIHdy b3RlOgo+IE9uIFdlZCwgT2N0IDMwLCAyMDI0IGF0IDAxOjU0OjU5UE0gKzA4MDAsIFFpYW5nIFl1 IHdyb3RlOgo+ID4gT24gMTAvMjQvMjAyNCAyOjQyIFBNLCBRaWFuZyBZdSB3cm90ZToKPiA+ID4g T24gMTAvMTgvMjAyNCAxMDowNiBQTSwgSm9oYW4gSG92b2xkIHdyb3RlOgo+IAo+ID4gPj4gQWxz byBzYXkgc29tZXRoaW5nIGFib3V0IGhvdyBMMHMgaXMgYnJva2VuIHNvIHRoYXQgaXQgaXMgbW9y ZSBjbGVhciB3aGF0Cj4gPiA+PiB0aGUgZWZmZWN0IG9mIHRoaXMgcGF0Y2ggaXMuIE9uIHNjODI4 MHhwIGVuYWJsaW5nIEwwcyBsZWFkIHRvCj4gPiA+PiBjb3JyZWN0YWJsZSBlcnJvcnMgZm9yIGV4 YW1wbGUuCj4gCj4gPiA+IE5lZWQgbW9yZSB0aW1lIHRvIGNvbmZpcm0gdGhlIGV4YWN0IHJlYXNv biBhYm91dCBkaXNhYmxpbmcgTDBzLgo+ID4gPiBXaWxsIHVwZGF0ZSBpZiBnZXQgYW55IHByb2dy ZXNzCj4gCj4gPiBJIGNvbmZpcm1lZCB3aXRoIEhXIHRlYW0gYW5kIFNXIHRlYW0uIEwwcyBpcyBu b3Qgc3VwcG9ydGVkIG9uIFgxRTgwMTAwLCAKPiA+IGl0IGlzIG5vdCBmdWxseSB2ZXJpZmllZC4g U28gd2UgZG9uJ3Qgd2FudCB0byBlbmFibGUgaXQuCj4gCj4gVGhhbmtzIGZvciBjaGVja2luZy4g QSB3b3JkIGFib3V0IHdoYXQgY2FuIGhhcHBlbiBpZiBub3QgZGlzYWJsaW5nIGl0Cj4gbWF5IHN0 aWxsIGJlIGluIHBsYWNlIChlLmcuIHRoZSBsaW5rIHN0YXRlIHRyYW5zaXRpb24gc3RhdHMgaW4g ZGVidWdmcwo+IG9uIHgxZTgwMTAwIGxvb2tlZCBwcmV0dHkgZXJyYXRpYyB3aXRoIEwwcyBlbmFi bGVkIElJUkMpLgo+IAo+IEFsc28sIGFyZSB0aGVyZSBhbnkgUXVhbGNvbW0gcGxhdGZvcm1zIHRo YXQgYWN0dWFsbHkgc3VwcG9ydCBMMHM/Cj4gUGVyaGFwcyB3ZSBzaG91bGQganVzdCBkaXNhYmxl IGl0IGV2ZXJ5d2hlcmU/Cj4gCgpNb3N0IG9mIHRoZSBtb2JpbGUgY2hpcHNldHMgZnJvbSBRY29t IHN1cHBvcnQgTDBzLiBJdCBpcyBub3Qgc3VwcG9ydGVkIG9ubHkgb24KdGhlIGNvbXB1dGUgb25l cy4gU28gd2UgY2Fubm90IGRpc2FibGUgaXQgZXZlcnl3aGVyZS4KCkFnYWluLCBpdCBpcyBub3Qg dGhlIGh3IGlzc3VlIGJ1dCB0aGUgUEhZIGluaXQgc2VxdWVuY2Ugbm90IHR1bmVkIHN1cHBvcnQg TDBzLgoKLSBNYW5pCgotLSAK4K6u4K6j4K6/4K614K6j4K+N4K6j4K6p4K+NIOCumuCupOCuvuCu muCuv+CuteCuruCvjQoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxpc3QKbGludXgtcGh5QGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtcGh5Cg==