From: Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Long Li <longli@microsoft.com>, Wei Hu <weh@microsoft.com>
Subject: Re: [PATCH] bus/vmbus: remove unnecessary packed attribute
Date: Wed, 30 Oct 2024 08:26:08 -0700 [thread overview]
Message-ID: <20241030082608.331f9355@hermes.local> (raw)
In-Reply-To: <CAJFAV8xWDXBxF+Ja+QSiPoZ6zPaycZ0Exm+89C1fY273JMKx3Q@mail.gmail.com>
On Wed, 30 Oct 2024 10:26:38 +0100
David Marchand <david.marchand@redhat.com> wrote:
> On Tue, Oct 22, 2024 at 4:37 AM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > The VMBus ring structure was marked packed which will cause
> > warnings if the no-address-of-packed is enabled. The structure
> > is all 32 bit values and the packed attribute has no impact
> > on the code layout; remove it.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> - Why only clean this structure in this header?
The patch was addressing the warning generated when the address
of packed member is re-enabled. The other usages are less of a problem
and cause no errors.
prev parent reply other threads:[~2024-10-30 15:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 2:37 [PATCH] bus/vmbus: remove unnecessary packed attribute Stephen Hemminger
2024-10-22 3:43 ` Wei Hu
2024-10-30 9:26 ` David Marchand
2024-10-30 15:05 ` Stephen Hemminger
2024-10-30 15:26 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241030082608.331f9355@hermes.local \
--to=stephen@networkplumber.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=longli@microsoft.com \
--cc=weh@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.