All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Wang <liwang@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] lib: Print failure hints only once to reduce log duplication
Date: Wed, 30 Oct 2024 16:45:58 +0800	[thread overview]
Message-ID: <20241030084558.195297-1-liwang@redhat.com> (raw)

The LTP test currently prints failure hints multiple times if a test
encounters several TFAIL or TBROK results. This leads to unnecessarily
verbose and duplicated logs.

This patch modifies the `print_failure_hints()` function to ensure that
failure hints are printed only once per test run. By setting `show_failure_hints`
to 0 after the first print, subsequent calls to `print_failure_hints()`
will not produce redundant output.

Fixes: 701212f08 ("Disable failure hints before we actually run the test")
Signed-off-by: Li Wang <liwang@redhat.com>
Cc: Cyril Hrubis <chrubis@suse.cz>
---
 lib/tst_test.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/tst_test.c b/lib/tst_test.c
index d942a91f1..8db554dea 100644
--- a/lib/tst_test.c
+++ b/lib/tst_test.c
@@ -911,6 +911,8 @@ static void print_failure_hints(void)
 	print_failure_hint("musl-git", "missing musl fixes", MUSL_GIT_URL);
 	print_failure_hint("CVE", "vulnerable to CVE(s)", CVE_DB_URL);
 	print_failure_hint("known-fail", "hit by known kernel failures", NULL);
+
+	show_failure_hints = 0;
 }
 
 static void do_exit(int ret)
-- 
2.46.2


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

             reply	other threads:[~2024-10-30  8:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30  8:45 Li Wang [this message]
2024-10-30 12:06 ` [LTP] [PATCH] lib: Print failure hints only once to reduce log duplication Petr Vorel
2024-10-30 12:14 ` Cyril Hrubis
2024-10-30 12:15   ` Cyril Hrubis
2024-10-31  2:33     ` Li Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241030084558.195297-1-liwang@redhat.com \
    --to=liwang@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.