From: Peter Zijlstra <peterz@infradead.org>
To: Tianchen Ding <dtcccc@linux.alibaba.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
Tejun Heo <tj@kernel.org>
Subject: Re: [RFC PATCH 2/2] sched/eevdf: Introduce a cgroup interface for slice
Date: Wed, 30 Oct 2024 12:00:56 +0100 [thread overview]
Message-ID: <20241030110056.GL14555@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20241028063313.8039-3-dtcccc@linux.alibaba.com>
On Mon, Oct 28, 2024 at 02:33:13PM +0800, Tianchen Ding wrote:
> Introduce "cpu.fair_slice" for cgroup v2 and "cpu.fair_slice_us" for v1
> according to their name styles. The unit is always microseconds.
>
> A cgroup with shorter slice can preempt others more easily. This could be
> useful in container scenarios.
>
> By default, cpu.fair_slice is 0, which means the slice of se is
> calculated by min_slice from its cfs_rq. If cpu.fair_slice is set, it
> will overwrite se->slice with the customized value.
So I'm not sure I like to expose this, like this.
The thing is, this is really specific to the way we schedule the cgroup
mess, fully hierarchical. If you want to collapse all this, like one of
those bpf schedulers does, then you cannot do this.
next prev parent reply other threads:[~2024-10-30 11:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 6:33 [RFC PATCH 0/2] sched/eevdf: Introduce a cgroup interface for slice Tianchen Ding
2024-10-28 6:33 ` [PATCH] sched/eevdf: Force propagating min_slice of cfs_rq when a task changing slice Tianchen Ding
2024-10-30 8:18 ` kernel test robot
2024-10-30 9:11 ` Tianchen Ding
2024-10-31 9:48 ` [PATCH v2] " Tianchen Ding
2024-11-12 3:25 ` Tianchen Ding
2024-11-13 11:50 ` 回复: " 解 咏梅
2024-11-14 2:45 ` Tianchen Ding
2024-11-14 6:06 ` 回复: " 解 咏梅
2024-11-14 6:36 ` Tianchen Ding
[not found] ` <ME0P300MB041447EBB0A17918745695898E5B2@ME0P300MB0414.AUSP300.PROD.OUTLOOK.COM>
2024-11-14 7:47 ` Tianchen Ding
2024-11-14 13:44 ` 回复: " 解 咏梅
2024-10-28 6:33 ` [RFC PATCH 2/2] sched/eevdf: Introduce a cgroup interface for slice Tianchen Ding
2024-10-28 17:37 ` Tejun Heo
2024-10-29 2:07 ` Tianchen Ding
2024-10-29 6:18 ` Tejun Heo
2024-10-29 6:49 ` Tianchen Ding
2024-10-29 20:39 ` Tejun Heo
[not found] ` <ME0P300MB0414F63E895B2F343EE740258E4B2@ME0P300MB0414.AUSP300.PROD.OUTLOOK.COM>
2024-10-29 4:26 ` 回复: " 解 咏梅
2024-10-30 11:00 ` Peter Zijlstra [this message]
2024-10-30 14:54 ` Tianchen Ding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241030110056.GL14555@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=dtcccc@linux.alibaba.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.