Re: [Buildroot] [PATCH v3] package/python-pgcopy: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Scott,

James: question for you below.

On Wed, 30 Oct 2024 21:28:24 +0800
Scott Fan <fancp2007@gmail.com> wrote:

> > Are you sure python-psycopg2 and python-pytz are build-time
> > dependencies? I.e are they needed during the build, or only at runtime?  
> 
> In pgcopy's setup.py file, has the next line:
> install_requires=["psycopg2", "pytz"]
> 
> So I understand, those are build-time dependencies.

I'll let James comment on this, but I believe install_requires are
run-time dependencies, not build-time dependencies.

> Meanwhile, the psycopg2 module depends on postgres.
> Do I need to remove postgres dependency from this package?

If you select BR2_PACKAGE_PYTHON_PSYCOPG2, it will automatically select
BR2_PACKAGE_POSTGRESQL.

Now whether you need postgresql as a build-time dependency or not
depends on whether your package is building native code that links
against Postgresql libraries.

> > What is this hook needed? A small comment would be useful.  
> 
> The py2.py file is just for Python 2, it will cause compilation errors
> in Buildroot:
>   File "/usr/lib/python3.12/site-packages/pgcopy/errors/py2.py", line 19
>     raise newexc, None, sys.exc_info()[2]
>                 ^
> SyntaxError: invalid syntax
> 
> I'll add a comment before the hook definition.

Yes, good.

> This hook will be removed, i copied it from package/python-psycopg2,
> It is redundant.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot