All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Jeffrey Hugo <quic_jhugo@quicinc.com>
Cc: oe-kbuild-all@lists.linux.dev,
	Carl Vanderlip <quic_carlv@quicinc.com>,
	Bjorn Andersson <andersson@kernel.org>
Subject: [linux-next:master 6600/7771] drivers/accel/qaic/sahara.c:776:2-7: WARNING: NULL check before some freeing functions is not needed.
Date: Wed, 30 Oct 2024 17:48:32 +0800	[thread overview]
Message-ID: <202410301732.abF5Md4e-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   6fb2fa9805c501d9ade047fc511961f3273cdcb5
commit: 93accc16a8d45a44e1f51fdf2c6014feedb13d27 [6600/7771] accel/qaic: Add crashdump to Sahara
config: alpha-randconfig-r064-20241030 (https://download.01.org/0day-ci/archive/20241030/202410301732.abF5Md4e-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.3.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410301732.abF5Md4e-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/accel/qaic/sahara.c:776:2-7: WARNING: NULL check before some freeing functions is not needed.

vim +776 drivers/accel/qaic/sahara.c

   768	
   769	static void sahara_mhi_remove(struct mhi_device *mhi_dev)
   770	{
   771		struct sahara_context *context = dev_get_drvdata(&mhi_dev->dev);
   772	
   773		cancel_work_sync(&context->fw_work);
   774		cancel_work_sync(&context->dump_work);
   775		if (context->mem_dump)
 > 776			vfree(context->mem_dump);
   777		sahara_release_image(context);
   778		mhi_unprepare_from_transfer(mhi_dev);
   779	}
   780	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-10-30  9:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202410301732.abF5Md4e-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=andersson@kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=quic_carlv@quicinc.com \
    --cc=quic_jhugo@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.