From: Jakub Kicinski <kuba@kernel.org>
To: Maksym Kutsevol <max@kutsevol.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Breno Leitao <leitao@debian.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH net-next v4 2/2] netcons: Add udp send fail statistics to netconsole
Date: Wed, 30 Oct 2024 18:49:28 -0700 [thread overview]
Message-ID: <20241030184928.3273f76d@kernel.org> (raw)
In-Reply-To: <20241027-netcons-add-udp-send-fail-statistics-to-netconsole-v4-2-a8065a43c897@kutsevol.com>
On Sun, 27 Oct 2024 12:59:42 -0700 Maksym Kutsevol wrote:
> +struct netconsole_target_stats {
> + u64_stats_t xmit_drop_count;
> + u64_stats_t enomem_count;
> + struct u64_stats_sync syncp;
> +} __aligned(2 * sizeof(u64));
Why the alignment?
> +static void netpoll_send_udp_count_errs(struct netconsole_target *nt,
> + const char *msg, int len)
This is defined in the netconsole driver, it should not use the
netpoll_ prefix for the function name.
next prev parent reply other threads:[~2024-10-31 1:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-27 19:59 [PATCH net-next v4 0/2] netcons: Add udp send fail statistics to netconsole Maksym Kutsevol
2024-10-27 19:59 ` [PATCH net-next v4 1/2] netpoll: Make netpoll_send_udp return status instead of void Maksym Kutsevol
2024-10-28 10:45 ` Breno Leitao
2024-10-27 19:59 ` [PATCH net-next v4 2/2] netcons: Add udp send fail statistics to netconsole Maksym Kutsevol
2024-10-28 10:45 ` Breno Leitao
2024-10-31 1:49 ` Jakub Kicinski [this message]
2024-11-01 1:19 ` Maksym Kutsevol
2024-11-01 1:49 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241030184928.3273f76d@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=leitao@debian.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max@kutsevol.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.