Re: [LTP] [PATCH v6 1/3] Refactor regen.sh script to generate syscalls

[Petr Vorel <pvorel@suse.cz>]

Hi Andrea,

whole patchset LGTM, thank you!

I was comparing the old include/lapi/syscalls.h (21579 lines) and the new one
(20054). Having new file shorter is a bit surprising to me. I haven't found what
is missing, probably I'm missing something myself :).

> Rename regen.sh into a more meaningful generate_syscalls.sh name, rename
> order into a more meaningful supported-syscalls.txt name and rewrite
> part of the regen.sh script code in order to execute it from anywhere in
> the filesystem, without need to be in its own folder. The new code is
> also more clear and concise, using native sh features which are
> simplifying the code.

Purely out of curiosity (nothing to block this), which "native sh features"?

> +++ b/include/lapi/syscalls/generate_syscalls.sh
...
> +SCRIPT_DIR="$(realpath $(dirname "$0"))"
> +SUPPORTED_ARCH="${SCRIPT_DIR}/supported-arch.txt"
> +
> +echo '
> +// SPDX-License-Identifier: GPL-2.0-or-later

very nit stylish: This produce new line. Why not just:

echo '// SPDX-License-Identifier: GPL-2.0-or-later
/************************************************

Feel free to ignore or amend before push.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp