From: Lee Jones <lee@kernel.org>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>,
Patrick Rudolph <patrick.rudolph@9elements.com>,
Naresh Solanki <Naresh.Solanki@9elements.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] leds: max5970: use cleanup facility for fwnode_handle led_node
Date: Thu, 31 Oct 2024 16:14:34 +0000 [thread overview]
Message-ID: <20241031161434.GK10824@google.com> (raw)
In-Reply-To: <20241019-max5970-of_node_put-v1-2-e6ce4af4119b@gmail.com>
On Sat, 19 Oct 2024, Javier Carrasco wrote:
> Add the automatic cleanup facility for 'led_node' to simplify the code
> and make it more robust against new error paths where omitting a call to
> fwnode_handle_put() would leak memory.
>
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> ---
> drivers/leds/leds-max5970.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
This makes patch 1 completely pointless.
Please squash them and resubmit.
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2024-10-31 16:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-19 19:36 [PATCH 0/2] leds: max5970: fix unreleased fwnode_handle in probe function Javier Carrasco
2024-10-19 19:36 ` [PATCH 1/2] " Javier Carrasco
2024-10-31 16:12 ` (subset) " Lee Jones
2024-10-31 16:14 ` Lee Jones
2024-10-19 19:36 ` [PATCH 2/2] leds: max5970: use cleanup facility for fwnode_handle led_node Javier Carrasco
2024-10-31 16:14 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241031161434.GK10824@google.com \
--to=lee@kernel.org \
--cc=Naresh.Solanki@9elements.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=patrick.rudolph@9elements.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.