From: Jakub Kicinski <kuba@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: horms@kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, thepacketgeek@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davej@codemonkey.org.uk, vlad.wing@gmail.com, max@kutsevol.com,
kernel-team@meta.com, jiri@resnulli.us, jv@jvosburgh.net,
andy@greyhouse.net, aehkn@xenhub.one,
Rik van Riel <riel@surriel.com>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH net-next 2/3] net: netpoll: Individualize the skb pool
Date: Thu, 31 Oct 2024 18:28:57 -0700 [thread overview]
Message-ID: <20241031182857.68d41c6f@kernel.org> (raw)
In-Reply-To: <20241025142025.3558051-3-leitao@debian.org>
On Fri, 25 Oct 2024 07:20:19 -0700 Breno Leitao wrote:
> The current implementation of the netpoll system uses a global skb pool,
> which can lead to inefficient memory usage and waste when targets are
> disabled or no longer in use.
>
> This can result in a significant amount of memory being unnecessarily
> allocated and retained, potentially causing performance issues and
> limiting the availability of resources for other system components.
>
> Modify the netpoll system to assign a skb pool to each target instead of
> using a global one.
>
> This approach allows for more fine-grained control over memory
> allocation and deallocation, ensuring that resources are only allocated
> and retained as needed.
If memory consumption is a concern then having n pools for n targets
rather than one seems even worse?
Is it not better to flush the pool when last target gets disabled?
next prev parent reply other threads:[~2024-11-01 1:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 14:20 [PATCH net-next 0/3] net: netpoll: Improve SKB pool management Breno Leitao
2024-10-25 14:20 ` [PATCH net-next 1/3] net: netpoll: Defer skb_pool population until setup success Breno Leitao
2024-11-01 1:26 ` Jakub Kicinski
2024-11-01 10:51 ` Breno Leitao
2024-11-01 18:18 ` Breno Leitao
2024-11-02 2:01 ` Jakub Kicinski
2024-11-04 20:40 ` Breno Leitao
2024-11-06 1:00 ` Jakub Kicinski
2024-11-06 15:06 ` Breno Leitao
2024-11-06 23:43 ` Jakub Kicinski
2024-11-07 11:50 ` Breno Leitao
2024-10-25 14:20 ` [PATCH net-next 2/3] net: netpoll: Individualize the skb pool Breno Leitao
2024-11-01 1:28 ` Jakub Kicinski [this message]
2024-11-01 11:56 ` Breno Leitao
2024-10-25 14:20 ` [PATCH net-next 3/3] net: netpoll: flush skb pool during cleanup Breno Leitao
2024-11-01 1:29 ` Jakub Kicinski
2024-11-01 11:57 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241031182857.68d41c6f@kernel.org \
--to=kuba@kernel.org \
--cc=aehkn@xenhub.one \
--cc=andy@greyhouse.net \
--cc=davej@codemonkey.org.uk \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=jv@jvosburgh.net \
--cc=kernel-team@meta.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max@kutsevol.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=riel@surriel.com \
--cc=thepacketgeek@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=vlad.wing@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.