From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v2 nf-next 0/7] netfilter: nf_tables: avoid PROVE_RCU_LIST splats
Date: Thu, 31 Oct 2024 22:56:45 +0100 [thread overview]
Message-ID: <20241031215645.GB4460@breakpoint.cc> (raw)
In-Reply-To: <ZyP7Q94DCbwBmobU@calendula>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > This targets nf-next because these are long-standing issues.
>
> This series breaks inner matching, I can see tests/shell reports:
>
> I: conf: NFT_TEST_HAVE_inner_matching=n
Uh, didn't i fix this in v2? V1 had a bug in patch 6:
+ if (!type->inner_ops || type->owner) {
+ err = -EOPNOTSUPP;
V1 had !type->owner, which causes feature probe to fail and the test to
skip (it skips builtin instead of module...).
I re-tested, I get:
I: conf: NFT_TEST_HAVE_inner_matching=y
next prev parent reply other threads:[~2024-10-31 21:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 9:40 [PATCH v2 nf-next 0/7] netfilter: nf_tables: avoid PROVE_RCU_LIST splats Florian Westphal
2024-10-30 9:40 ` [PATCH v2 nf-next 1/7] netfilter: nf_tables: avoid false-positive lockdep splat on rule deletion Florian Westphal
2024-10-30 9:40 ` [PATCH v2 nf-next 2/7] netfilter: nf_tables: avoid false-positive lockdep splats with sets Florian Westphal
2024-10-30 9:40 ` [PATCH v2 nf-next 3/7] netfilter: nf_tables: avoid false-positive lockdep splats with flowtables Florian Westphal
2024-10-30 9:40 ` [PATCH v2 nf-next 4/7] netfilter: nf_tables: avoid false-positive lockdep splats in set walker Florian Westphal
2024-10-30 9:40 ` [PATCH v2 nf-next 5/7] netfilter: nf_tables: avoid false-positive lockdep splats with basechain hook Florian Westphal
2024-10-30 9:40 ` [PATCH v2 nf-next 6/7] netfilter: nf_tables: must hold rcu read lock while iterating expression type list Florian Westphal
2024-10-30 9:40 ` [PATCH v2 nf-next 7/7] netfilter: nf_tables: must hold rcu read lock while iterating object " Florian Westphal
2024-11-01 7:07 ` Dan Carpenter
2024-10-30 10:40 ` [PATCH v2 nf-next 0/7] netfilter: nf_tables: avoid PROVE_RCU_LIST splats Pablo Neira Ayuso
2024-10-31 21:48 ` Pablo Neira Ayuso
2024-10-31 21:56 ` Florian Westphal [this message]
2024-10-31 21:59 ` Pablo Neira Ayuso
2024-10-31 22:42 ` Pablo Neira Ayuso
2024-10-31 23:02 ` Florian Westphal
2024-10-31 23:22 ` Florian Westphal
2024-10-31 23:28 ` Pablo Neira Ayuso
2024-10-31 23:25 ` Pablo Neira Ayuso
2024-10-31 23:37 ` Florian Westphal
2024-11-01 7:31 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241031215645.GB4460@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.